Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remote: Comment form styles #5580

Merged
merged 5 commits into from
Mar 9, 2022
Merged

Remote: Comment form styles #5580

merged 5 commits into from
Mar 9, 2022

Conversation

matiasbenedetto
Copy link
Member

@matiasbenedetto matiasbenedetto commented Feb 23, 2022 •
edited
Loading

Changes proposed in this Pull Request:

Remote: Comment form styles

Related issue(s):

#5501

@matiasbenedetto matiasbenedetto changed the base branch from trunk to update/5509 February 23, 2022 18:21
@jffng
Copy link
Contributor

jffng commented Feb 24, 2022

Here is a corresponding wpcom patch D75679-code required to not break the comment form there.

@scruffian
Copy link
Member

@kjellr do you think it's worth the custom CSS for this?

@matiasbenedetto matiasbenedetto changed the base branch from update/5509 to trunk February 25, 2022 13:39
@kjellr
Copy link
Contributor

kjellr commented Feb 25, 2022

@kjellr do you think it's worth the custom CSS for this?

I think the CSS that styles the form fields is fine, but I would leave out the grid stuff, since it's not strictly necessary to re-arrange items.

@matiasbenedetto
Copy link
Member Author

@kjellr this is the mockup:
image

This is the styles implementation with grid:
image

This is the syles implementation without grid:
image

Should we remove the grid css?

@kjellr
Copy link
Contributor

kjellr commented Mar 2, 2022

That's fine. We should fix the padding on the submit button too while we're at it.

@matiasbenedetto
Copy link
Member Author

That's fine. We should fix the padding on the submit button too while we're at it.

@kjellr sorry but I didn't get what is fine. Should we remove the grid CSS or not?

@kjellr
Copy link
Contributor

kjellr commented Mar 2, 2022

Yes, please remove the grid.

@pbking pbking linked an issue Mar 7, 2022 that may be closed by this pull request
Remote: Comment form styles (dotcom and dotorg) (if needed) #5501
Closed
pbking
pbking approved these changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@pbking pbking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
🚢

@mikachan mikachan merged commit 19c7c12 into trunk Mar 9, 2022
@mikachan mikachan deleted the update/5501 branch March 9, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbking pbking pbking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remote: Comment form styles (dotcom and dotorg) (if needed)
6 participants
@matiasbenedetto @jffng @scruffian @kjellr @pbking @mikachan