Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form: Add style variations #28212

Merged
merged 63 commits into from
Feb 3, 2023
Merged

Form: Add style variations #28212

merged 63 commits into from
Feb 3, 2023

Conversation

jcheringer
Copy link
Contributor

@jcheringer jcheringer commented Jan 6, 2023

Fixes #28166

Proposed changes:

  • Includes 2 new Form styles: Outlined and Animated

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

pcsBup-Gl-p2

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Create a post and add a Form block
  • Change the form style in the Sidebar to the new styles
  • Add some fields and play with the form to ensure everything works as expected

@jcheringer jcheringer added the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Feb 1, 2023
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tests well for me in Jetpack, and in the post editor on WordPress.com Simple.

In the site editor, however, the blurring effect stays there whenever I add a form to the site editor:

image

This doesn't seem to happen on trunk, so this may be caused by this PR. Does this happen to you too?

@jeherve jeherve added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Feb 2, 2023
@jcheringer
Copy link
Contributor Author

This tests well for me in Jetpack, and in the post editor on WordPress.com Simple.

In the site editor, however, the blurring effect stays there whenever I add a form to the site editor:
This doesn't seem to happen on trunk, so this may be caused by this PR. Does this happen to you too?

Do you mean the "Editor" under the "Appearance" menu?
image

If so, I tested it on my WP site, and I noticed something weird.
After adding the Form block to the page, the blur effect persisted until I moved my mouse over the form.
But then I cleaned the page up by removing most of the content, and now I'm not able to reproduce it anymore.

Screen.Recording.on.2023-02-02.at.16_21_30.webm

@jeherve
Copy link
Member

jeherve commented Feb 3, 2023

Do you mean the "Editor" under the "Appearance" menu?

Yep, that's the one. 👍

I tested it on my WP site, and I noticed something weird.

Yes, that blur is problematic. Here is what I'm seeing on my end on WordPress.com Simple. I do not seem to have that issue without that branch applied:

Screen.Recording.2023-02-03.at.12.19.02.mov

@jcheringer
Copy link
Contributor Author

jcheringer commented Feb 3, 2023

Thanks for sharing the video @jeherve!
I couldn't reproduce it yet, but I don't want to hold this PR anymore because of that.
The blur effect was supposed to improve things a bit on the user side, but we can get back to it in a follow-up PR.
For now, I've removed the blur effect from the Editor.

cc @digitalwaveride

@jcheringer jcheringer requested a review from jeherve February 3, 2023 13:46
@jcheringer jcheringer added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Feb 3, 2023
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Contact Form Form block (also see Contact Form label) [Feature] Contact Form [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Status] Needs Test Review [Tests] Includes Tests Unit Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JP Form Block - Adding styles variations to form blocks (-> label placements)
8 participants