Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form block: Radio buttons have a reduced opacity #32332

Closed
aisajib opened this issue Feb 2, 2023 · 12 comments
Closed

Form block: Radio buttons have a reduced opacity #32332

aisajib opened this issue Feb 2, 2023 · 12 comments
Labels
[Block] Contact Form Form block (also see Contact Form label) Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" [Feature] Contact Form [Platform] Atomic [Platform] Simple [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended

Comments

@aisajib
Copy link

aisajib commented Feb 2, 2023

Quick summary

A user in the WordPress.com forum reported, and I replicated, that the radio buttons on the Form block on WordPress.com have a reduced opacity.

CleanShot 2023-02-02 at 09 13 34@2x

Steps to reproduce

  1. On a WordPress.com site, open the post/page editor.
  2. Insert a Form block. Choose any of the preset.
  3. Insert a Single Choice (Radio) field/button.
  4. Add a couple of options.
  5. Preview the post/page.

What you expected to happen

The text on the radio buttons should have full opacity.

CleanShot 2023-02-02 at 09 15 27@2x

The screenshot above is from a self-hosted site using Jetpack.

What actually happened

The text looks like this with reduced opacity:

CleanShot 2023-02-02 at 09 16 09@2x

Impact

All

Available workarounds?

Yes, easy to implement

Platform (Simple and/or Atomic)

Simple, Atomic

Logs or notes

I was able to replicate it on both FSE and non-FSE themes. But on a self-hosted site, this didn't happen.

@aisajib aisajib added [Type] Bug When a feature is broken and / or not performing as intended User Report labels Feb 2, 2023
@NoHopeRadio
Copy link

NoHopeRadio commented Feb 4, 2023

I believe the issue is that the radio button labels are now being treated the same as the (required) labels in other fields. One user previously had these labels replaced via CSS, and found the radio button labels missing suddenly, with the opacity change as well.

I recommended adding a label:not(.radio) into their custom CSS (which might also be a fix for us to implement), and the inverse for changing the opacity back.

40300715-hc

@aisajib
Copy link
Author

aisajib commented Feb 4, 2023

Thanks @NoHopeRadio ! As this affects free users as well who don't have access to custom CSS without a plan or an add-on upgrade, hopefully we can ship a fix soon!

@sophiegyo
Copy link

The same's happening for multiple choice checkboxes, though oddly enough not for single checkboxes.

@carinapilar
Copy link

Got another report on: 5933725-zd-woothemes - shared the following CSS:

/* Fix for radio buttons on Form block */
.contact-form label.radio span {
	opacity: 1;
}

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023

Support References

This comment is automatically generated. Please do not edit it.

@dpasque
Copy link
Contributor

dpasque commented Feb 16, 2023

@aisajib I believe this was just fixed recently by this PR: #28212 🎉

I wasn't seeing this reproducing on WPCOM -- are you still seeing that? If not, we should be able to close this as fixed! 🥳

@dpasque dpasque added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Feb 16, 2023
@aisajib
Copy link
Author

aisajib commented Feb 16, 2023

I've checked my test sites, and I'm not able to reproduce it. :)

@dpasque
Copy link
Contributor

dpasque commented Feb 16, 2023

Excellent, I will close! Fixed by #28212

@dpasque dpasque closed this as completed Feb 16, 2023
@Gustavo-Hilario
Copy link

Gustavo-Hilario commented Jun 2, 2023

We got another report about this here:

6345849-zen

I could also reproduce this issue on a test site using the Marl theme. The opacity rule isn't applied to the editor, so when users check the preview or published page, they see a different color. I'm reopening this for now.

Edit: I couldn't replicate this on a Simple Site using Marl.

@cuemarie
Copy link

cuemarie commented Aug 7, 2023

Reopened Issue


📌 SCRUBBING : RESULT - Replicated / Could Not Replicate / Uncertain

  • Tested on Simple – Could Not Replicate
  • Tested on Atomic – Replicated

📌 FINDINGS/SCREENSHOTS/VIDEO

  • Using TT3 on both platforms, the Form Block's radio buttons had an opacity on the AT site only.

Screenshots/Recordings

Atomic, TT3
Markup on 2023-08-07 at 14:30:44

Simple, TT3
Markup on 2023-08-07 at 14:33:54

📌 ACTIONS

@cuemarie cuemarie added [Block] Contact Form Form block (also see Contact Form label) and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! [Platform] Simple labels Aug 7, 2023
@jeherve jeherve transferred this issue from Automattic/wp-calypso Aug 8, 2023
@jeherve jeherve added Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" and removed User Report labels Dec 18, 2024
@ntsekouras
Copy link
Member

Is this still valid? I couldn't reproduce it.

@jeherve jeherve closed this as completed Jan 9, 2025
@jeherve
Copy link
Member

jeherve commented Jan 9, 2025

Closing this for now because of the lack of activity on this. We can always reopen in the future if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Contact Form Form block (also see Contact Form label) Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" [Feature] Contact Form [Platform] Atomic [Platform] Simple [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

No branches or pull requests

9 participants