Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contact Form: multiple choice checkbox labels are semi-transparent #72993

Closed
sophiegyo opened this issue Feb 6, 2023 · 3 comments
Closed

Contact Form: multiple choice checkbox labels are semi-transparent #72993

sophiegyo opened this issue Feb 6, 2023 · 3 comments
Labels
[Block] Contact Form [Platform] Atomic [Platform] Simple [Pri] High Address as soon as possible after BLOCKER issues [Type] Bug When a feature is broken and / or not performing as intended

Comments

@sophiegyo
Copy link

sophiegyo commented Feb 6, 2023

Quick summary

Checkbox labels have partial opacity in their CSS, rendering them harder to see and read.

We've had a couple of user reports about this:
https://wordpress.com/forums/topic/faded-words-in-my-contact-forms/?view=all&spf_use_2022_style=yes
https://wordpress.com/forums/topic/how-to-change-color-of-checkbox-radio-form-block/?view=all

I'm now convinced it's bug-report-worthy.

I've tested on a self-hosted site using Jetpack and that's fine, this seems to be exclusive to wpcom.
Incidentally, the first report linked above actually uses a classic block, and therefore a classic/shortcode contact form, but this affects old and current contact forms alike.

Steps to reproduce

  1. Start at any wpcom Simple or Atomic site, any theme
  2. Create a page, insert a contact form
  3. Add a multiple choice checkboxes
  4. Preview in a new tab or publish the page

What you expected to happen

The multiple choice checkboxes should not be faded and therefore harder to read, like this screenshot from my self-hosted site using WP 6.1.1, Jetpack 11.7.1, and Gutenberg 15.0.1

image

What actually happened

The multiple choice checkboxes are faded - screenshot from my Atomic site:

image

Same with Simple:

image

Screenshot including the CSS on my Simple site:

image

Impact

Most (> 50%)

Available workarounds?

No but the platform is still usable

Platform (Simple and/or Atomic)

Simple, Atomic

Logs or notes

Plugin version: Jetpack 11.7.1
Browser: Firefox 109.0.1
Mac OS: 12.6

I tried seeing if the field text colour setting would affect anything, but it did not.

@sophiegyo sophiegyo added [Type] Bug When a feature is broken and / or not performing as intended User Report [Block] Contact Form labels Feb 6, 2023
@github-actions github-actions bot added [Platform] Atomic [Platform] Simple [Pri] High Address as soon as possible after BLOCKER issues labels Feb 6, 2023
@sophiegyo sophiegyo changed the title Contact Form: checkbox labels are semi-transparent Contact Form: multiple choice checkbox labels are semi-transparent Feb 6, 2023
@sophiegyo
Copy link
Author

Judging from the comment on a similar issue for radio buttons, it is what I thought - the opacity that was originally for "required" labels is applying to other labels too.

@dpasque
Copy link
Contributor

dpasque commented Feb 16, 2023

@sophiegyo I think this is actually fixed! There's quite the comical race condition here of timing going on here... 😆

Here's what my testing showed as of today:

  • Testing on a DotCom Simple Site (running Jetpack 11.9 a3): did not reproduce
  • Testing on a Jurassic Ninja site running Jetpack 11.8.4: does reproduce.

From what I can tell, this was actually fixed in this Jetpack PR: Automattic/jetpack#28212 -- it strips the span wrapper on the checkbox label, which was what was causing the bad styling.

That PR was included in 11.9 a1, which deployed to simple late last week (not long after this was opened! The timing! How about that turn around? 😁 ): p8oabR-156-p2

So, I think that's why it's now fixed on WPCOM, and it should be fixed for everyone else once we release 11.9 publicly and they add it to their self hosted sites.

@sophiegyo would you mind double checking whether this is still reproducing on WPCOM for you?

If not, we can close this as fixed! 🥳

@vajrasar
Copy link

Closing this. @sophiegyo pls feel free to reopen if you can still replicate this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Contact Form [Platform] Atomic [Platform] Simple [Pri] High Address as soon as possible after BLOCKER issues [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

No branches or pull requests

3 participants