Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False-positive for "Subordinating conjunctions should not appear at the end of a clause." #341

Closed
jvoisin opened this issue Dec 30, 2024 · 2 comments
Closed

False-positive for "Subordinating conjunctions should not appear at the end of a clause." #341

jvoisin opened this issue Dec 30, 2024 · 2 comments
Assignees
@elijah-potter
Labels
harper-core

Comments

@jvoisin
Copy link

jvoisin commented Dec 30, 2024

I'm getting a "Subordinating conjunctions like “only,” should not appear at the end of a clause." diagnostic on the following sentence:

The structure has a couple of fields marked read-only, like A and B

An easy fix would be to check if the conjunction is preceded by a space character.
@elijah-potter elijah-potter self-assigned this Jan 2, 2025
@elijah-potter
Copy link
Collaborator

Thanks for bringing this up. I've implemented a rough solution to this. It will be out in the next release. Mind if I ping you when that happens so you can confirm that it's working on your end?

elijah-potter added a commit that referenced this issue Jan 2, 2025
@elijah-potter
fix(core): #341 by adding check to make sure we don't include *-only
b56af6b
@jvoisin
Copy link
Author

jvoisin commented Jan 2, 2025

I'll update the issue once the release is out, and I can confirm that it fixes the issue, no worries :)

@jvoisin jvoisin closed this as completed Jan 9, 2025
@BrewTestBot BrewTestBot mentioned this issue Jan 15, 2025
Merged
tmeijn pushed a commit to tmeijn/dotfiles that referenced this issue Jan 22, 2025
@tmeijn
build(deps): update automattic/harper/harper-ls to v0.16.0
b3a707b 
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [Automattic/harper/harper-ls](https://github.com/Automattic/harper) | minor | `v0.14.0` -> `v0.16.0` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>Automattic/harper (Automattic/harper/harper-ls)</summary>

### [`v0.16.0`](https://github.com/Automattic/harper/releases/tag/v0.16.0)

[Compare Source](Automattic/harper@v0.15.0...v0.16.0)

#### What's Changed

-   [A false-positive for subordinating conjunctions was resolved](Automattic/harper#341).
-   [harper.js now properly reexports types from harper-wasm](Automattic/harper@aad7519).
-   [harper.js now has an automatically generated API reference page.](https://writewithharper.com/docs/harperjs/ref/harper.js.html)
-   [Some erroneous filtering of certain errors was creating false-negatives.](Automattic/harper#131)
-   [Words containing numbers are less likely to throw false-positive spelling errors.](Automattic/harper#195)
-   [A rule for variations of the word “your” was added](Automattic/harper@113bc36).
-   fix the nvim-lspconfig link by [@&#8203;wadsaek](https://github.com/wadsaek) in Automattic/harper#367
-   docs: added Scoop instructions by [@&#8203;elijah-potter](https://github.com/elijah-potter) in Automattic/harper#361
-   Enable LTO and codegen-units = 1 in the Release profile by [@&#8203;zamazan4ik](https://github.com/zamazan4ik) in Automattic/harper#363
-   feat([#&#8203;331](Automattic/harper#331)): Literate Haskell Support by [@&#8203;grantlemons](https://github.com/grantlemons) in Automattic/harper#344
-   build(deps): bump dirs from 5.0.1 to 6.0.0 by [@&#8203;dependabot](https://github.com/dependabot) in Automattic/harper#372
-   build(deps): bump tokio from 1.42.0 to 1.43.0 by [@&#8203;dependabot](https://github.com/dependabot) in Automattic/harper#371
-   build(deps): bump thiserror from 2.0.9 to 2.0.11 by [@&#8203;dependabot](https://github.com/dependabot) in Automattic/harper#369
-   feat: Typst Language Support by [@&#8203;grantlemons](https://github.com/grantlemons) in Automattic/harper#302
-   build(deps): bump serde_json from 1.0.134 to 1.0.135 by [@&#8203;dependabot](https://github.com/dependabot) in Automattic/harper#368
-   feat(core): create new linter for dollar sign placement by [@&#8203;elijah-potter](https://github.com/elijah-potter) in Automattic/harper#376
-   refactor: Harper-ls Error-Handling Improvements by [@&#8203;grantlemons](https://github.com/grantlemons) in Automattic/harper#349
-   feat([#&#8203;104](Automattic/harper#104)): Markdown linter config for ignoring link titles by [@&#8203;grantlemons](https://github.com/grantlemons) in Automattic/harper#305
-   feat(harper.js): added ability to configure the markup language by [@&#8203;elijah-potter](https://github.com/elijah-potter) in Automattic/harper#379
-   feat(vscode-plugin): Add Literate Haskell and Typst Support + some doc updates by [@&#8203;mcecode](https://github.com/mcecode) in Automattic/harper#388

#### New Contributors

-   [@&#8203;wadsaek](https://github.com/wadsaek) made their first contribution in Automattic/harper#367
-   [@&#8203;elijah-potter](https://github.com/elijah-potter) made their first contribution in Automattic/harper#361
-   [@&#8203;zamazan4ik](https://github.com/zamazan4ik) made their first contribution in Automattic/harper#363

**Full Changelog**: Automattic/harper@v0.15.0...v0.16.0

### [`v0.15.0`](https://github.com/Automattic/harper/releases/tag/v0.15.0)

[Compare Source](Automattic/harper@v0.14.0...v0.15.0)

#### What's Changed

-   Added a variety of rules (see [complete list here](https://writewithharper.com/docs/rules)).
-   Fixed issues with parsing hostnames
-   Added a variety of available `Pattern`s for downstream use
-   Update +page.md by [@&#8203;aminwhat](https://github.com/aminwhat) in Automattic/harper#347
-   feat: Add technical words to dictionary by [@&#8203;claydugo](https://github.com/claydugo) in Automattic/harper#343
-   refactor: remove raw hashes that are unnecessary by [@&#8203;hamirmahal](https://github.com/hamirmahal) in Automattic/harper#324
-   feat: Span View Command Improvements by [@&#8203;grantlemons](https://github.com/grantlemons) in Automattic/harper#340
-   Address "one" for indefinite article rule by [@&#8203;claydugo](https://github.com/claydugo) in Automattic/harper#359
-   feat: Add support for cmake files by [@&#8203;alcroito](https://github.com/alcroito) in Automattic/harper#353
-   build(deps): bump itertools from 0.13.0 to 0.14.0 by [@&#8203;dependabot](https://github.com/dependabot) in Automattic/harper#357
-   feat(harper-ls): remove deleted file/s diagnostics by [@&#8203;mcecode](https://github.com/mcecode) in Automattic/harper#304
-   feat(vscode-plugin): Add CMake Support by [@&#8203;mcecode](https://github.com/mcecode) in Automattic/harper#360

#### New Contributors

-   [@&#8203;aminwhat](https://github.com/aminwhat) made their first contribution in Automattic/harper#347
-   [@&#8203;hamirmahal](https://github.com/hamirmahal) made their first contribution in Automattic/harper#324
-   [@&#8203;alcroito](https://github.com/alcroito) made their first contribution in Automattic/harper#353

**Full Changelog**: Automattic/harper@v0.14.0...v0.15.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS45My4wIiwidXBkYXRlZEluVmVyIjoiMzkuMTA3LjAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbIlJlbm92YXRlIEJvdCJdfQ==-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elijah-potter elijah-potter

Labels
harper-core
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jvoisin @elijah-potter