Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FR: Option to disable in Markdown links #104

Open
chrisgrieser opened this issue Aug 7, 2024 · 2 comments
Open

FR: Option to disable in Markdown links #104

chrisgrieser opened this issue Aug 7, 2024 · 2 comments
Assignees
@grantlemons

Comments

@chrisgrieser
Copy link

Could there be an option to disable spellchecking the content of markdown links? There are many cases, where doing so just results in tons of false positives, e.g. in the list of GitHub repos.

ltex does have a setting to configure whether code blocks, inline code, or links should be spellchecked, and it would be useful if harper had such a setting as well.

Pasted image 2024-08-07 at 12 18 36@2x
@elijah-potter
Copy link
Collaborator

Absolutely! I've got some changes stashed that I want to polish first, but then it'll be top priority.

@chrisgrieser chrisgrieser mentioned this issue Oct 16, 2024
Open
@elijah-potter
Copy link
Collaborator

elijah-potter commented Oct 16, 2024 •
edited
Loading

but then it'll be top priority.

🧢

Sorry about that. @grantlemons, could you take this up? It should be pretty straightforward. I'd add an option to the Markdown parser to emit Unlintables for all tokens found inside a link.

@elijah-potter elijah-potter pinned this issue Oct 16, 2024
grantlemons added a commit that referenced this issue Oct 17, 2024
@grantlemons
feat(#104): process links as unlintable (not as a config option yet)
dd038a9
@grantlemons grantlemons self-assigned this Oct 17, 2024
grantlemons added a commit that referenced this issue Oct 27, 2024
@grantlemons
feat(#104): process links as unlintable (not as a config option yet)
0cac71f
grantlemons added a commit to grantlemons/harper that referenced this issue Dec 6, 2024
@grantlemons
feat(Automattic#104): process links as unlintable (not as a config op…
a38c8cc 
…tion yet)
grantlemons added a commit to grantlemons/harper that referenced this issue Dec 6, 2024
@grantlemons
feat(Automattic#104): process links as unlintable (not as a config op…
72a1596 
…tion yet)
grantlemons added a commit to grantlemons/harper that referenced this issue Dec 6, 2024
@grantlemons
feat(Automattic#104): add config options to markdown struct
183f07d
grantlemons added a commit to grantlemons/harper that referenced this issue Dec 6, 2024
@grantlemons
feat(Automattic#104): propagate markdown config options through project
0a4121f
@grantlemons grantlemons mentioned this issue Dec 6, 2024
Merged
grantlemons added a commit to grantlemons/harper that referenced this issue Dec 6, 2024
@grantlemons
fix(Automattic#104): return to old behavior when option disabled
3106833
grantlemons added a commit to grantlemons/harper that referenced this issue Dec 6, 2024
@grantlemons
style(Automattic#104): swap order of conditions to be more consistent
dc617a5
@elijah-potter elijah-potter unpinned this issue Jan 15, 2025
elijah-potter added a commit that referenced this issue Jan 15, 2025
@elijah-potter
Merge pull request #305 from grantlemons/ignore-link-title-cfg
04b65b3 
feat(#104): Markdown linter config for ignoring link titles
tmeijn pushed a commit to tmeijn/dotfiles that referenced this issue Jan 22, 2025
@tmeijn
build(deps): update automattic/harper/harper-ls to v0.16.0
b3a707b 
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [Automattic/harper/harper-ls](https://github.com/Automattic/harper) | minor | `v0.14.0` -> `v0.16.0` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>Automattic/harper (Automattic/harper/harper-ls)</summary>

### [`v0.16.0`](https://github.com/Automattic/harper/releases/tag/v0.16.0)

[Compare Source](Automattic/harper@v0.15.0...v0.16.0)

#### What's Changed

-   [A false-positive for subordinating conjunctions was resolved](Automattic/harper#341).
-   [harper.js now properly reexports types from harper-wasm](Automattic/harper@aad7519).
-   [harper.js now has an automatically generated API reference page.](https://writewithharper.com/docs/harperjs/ref/harper.js.html)
-   [Some erroneous filtering of certain errors was creating false-negatives.](Automattic/harper#131)
-   [Words containing numbers are less likely to throw false-positive spelling errors.](Automattic/harper#195)
-   [A rule for variations of the word “your” was added](Automattic/harper@113bc36).
-   fix the nvim-lspconfig link by [@&#8203;wadsaek](https://github.com/wadsaek) in Automattic/harper#367
-   docs: added Scoop instructions by [@&#8203;elijah-potter](https://github.com/elijah-potter) in Automattic/harper#361
-   Enable LTO and codegen-units = 1 in the Release profile by [@&#8203;zamazan4ik](https://github.com/zamazan4ik) in Automattic/harper#363
-   feat([#&#8203;331](Automattic/harper#331)): Literate Haskell Support by [@&#8203;grantlemons](https://github.com/grantlemons) in Automattic/harper#344
-   build(deps): bump dirs from 5.0.1 to 6.0.0 by [@&#8203;dependabot](https://github.com/dependabot) in Automattic/harper#372
-   build(deps): bump tokio from 1.42.0 to 1.43.0 by [@&#8203;dependabot](https://github.com/dependabot) in Automattic/harper#371
-   build(deps): bump thiserror from 2.0.9 to 2.0.11 by [@&#8203;dependabot](https://github.com/dependabot) in Automattic/harper#369
-   feat: Typst Language Support by [@&#8203;grantlemons](https://github.com/grantlemons) in Automattic/harper#302
-   build(deps): bump serde_json from 1.0.134 to 1.0.135 by [@&#8203;dependabot](https://github.com/dependabot) in Automattic/harper#368
-   feat(core): create new linter for dollar sign placement by [@&#8203;elijah-potter](https://github.com/elijah-potter) in Automattic/harper#376
-   refactor: Harper-ls Error-Handling Improvements by [@&#8203;grantlemons](https://github.com/grantlemons) in Automattic/harper#349
-   feat([#&#8203;104](Automattic/harper#104)): Markdown linter config for ignoring link titles by [@&#8203;grantlemons](https://github.com/grantlemons) in Automattic/harper#305
-   feat(harper.js): added ability to configure the markup language by [@&#8203;elijah-potter](https://github.com/elijah-potter) in Automattic/harper#379
-   feat(vscode-plugin): Add Literate Haskell and Typst Support + some doc updates by [@&#8203;mcecode](https://github.com/mcecode) in Automattic/harper#388

#### New Contributors

-   [@&#8203;wadsaek](https://github.com/wadsaek) made their first contribution in Automattic/harper#367
-   [@&#8203;elijah-potter](https://github.com/elijah-potter) made their first contribution in Automattic/harper#361
-   [@&#8203;zamazan4ik](https://github.com/zamazan4ik) made their first contribution in Automattic/harper#363

**Full Changelog**: Automattic/harper@v0.15.0...v0.16.0

### [`v0.15.0`](https://github.com/Automattic/harper/releases/tag/v0.15.0)

[Compare Source](Automattic/harper@v0.14.0...v0.15.0)

#### What's Changed

-   Added a variety of rules (see [complete list here](https://writewithharper.com/docs/rules)).
-   Fixed issues with parsing hostnames
-   Added a variety of available `Pattern`s for downstream use
-   Update +page.md by [@&#8203;aminwhat](https://github.com/aminwhat) in Automattic/harper#347
-   feat: Add technical words to dictionary by [@&#8203;claydugo](https://github.com/claydugo) in Automattic/harper#343
-   refactor: remove raw hashes that are unnecessary by [@&#8203;hamirmahal](https://github.com/hamirmahal) in Automattic/harper#324
-   feat: Span View Command Improvements by [@&#8203;grantlemons](https://github.com/grantlemons) in Automattic/harper#340
-   Address "one" for indefinite article rule by [@&#8203;claydugo](https://github.com/claydugo) in Automattic/harper#359
-   feat: Add support for cmake files by [@&#8203;alcroito](https://github.com/alcroito) in Automattic/harper#353
-   build(deps): bump itertools from 0.13.0 to 0.14.0 by [@&#8203;dependabot](https://github.com/dependabot) in Automattic/harper#357
-   feat(harper-ls): remove deleted file/s diagnostics by [@&#8203;mcecode](https://github.com/mcecode) in Automattic/harper#304
-   feat(vscode-plugin): Add CMake Support by [@&#8203;mcecode](https://github.com/mcecode) in Automattic/harper#360

#### New Contributors

-   [@&#8203;aminwhat](https://github.com/aminwhat) made their first contribution in Automattic/harper#347
-   [@&#8203;hamirmahal](https://github.com/hamirmahal) made their first contribution in Automattic/harper#324
-   [@&#8203;alcroito](https://github.com/alcroito) made their first contribution in Automattic/harper#353

**Full Changelog**: Automattic/harper@v0.14.0...v0.15.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS45My4wIiwidXBkYXRlZEluVmVyIjoiMzkuMTA3LjAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbIlJlbm92YXRlIEJvdCJdfQ==-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grantlemons grantlemons

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@grantlemons @elijah-potter @chrisgrieser