"Than" must have word following #131
Labels
Comments
|
Thanks for the feedback! I've got a linter working for the first issue, and am working on one for the second issue. It should be available in the most recent release. Feel free to give it a whirl and let me know if you find any problems. |
|
It looks like this has been resolved. If that isn't the case, feel free to reopen the issue. |
|
Just tried it on https://writewithharper.com/, and the issue persists there. |
elijah-potter
added a commit
that referenced
this issue
Jan 14, 2025
|
It turns out it was still happening on the website due to a bug specific to that target. It should be resolved now (you may have to clear your cache). Would you mind confirming? Thanks again for letting me know! |
|
Now the "than" error is detected, but not the "the of" one. |
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this issue
Jan 22, 2025
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [Automattic/harper/harper-ls](https://github.com/Automattic/harper) | minor | `v0.14.0` -> `v0.16.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>Automattic/harper (Automattic/harper/harper-ls)</summary> ### [`v0.16.0`](https://github.com/Automattic/harper/releases/tag/v0.16.0) [Compare Source](Automattic/harper@v0.15.0...v0.16.0) #### What's Changed - [A false-positive for subordinating conjunctions was resolved](Automattic/harper#341). - [harper.js now properly reexports types from harper-wasm](Automattic/harper@aad7519). - [harper.js now has an automatically generated API reference page.](https://writewithharper.com/docs/harperjs/ref/harper.js.html) - [Some erroneous filtering of certain errors was creating false-negatives.](Automattic/harper#131) - [Words containing numbers are less likely to throw false-positive spelling errors.](Automattic/harper#195) - [A rule for variations of the word “your” was added](Automattic/harper@113bc36). - fix the nvim-lspconfig link by [@​wadsaek](https://github.com/wadsaek) in Automattic/harper#367 - docs: added Scoop instructions by [@​elijah-potter](https://github.com/elijah-potter) in Automattic/harper#361 - Enable LTO and codegen-units = 1 in the Release profile by [@​zamazan4ik](https://github.com/zamazan4ik) in Automattic/harper#363 - feat([#​331](Automattic/harper#331)): Literate Haskell Support by [@​grantlemons](https://github.com/grantlemons) in Automattic/harper#344 - build(deps): bump dirs from 5.0.1 to 6.0.0 by [@​dependabot](https://github.com/dependabot) in Automattic/harper#372 - build(deps): bump tokio from 1.42.0 to 1.43.0 by [@​dependabot](https://github.com/dependabot) in Automattic/harper#371 - build(deps): bump thiserror from 2.0.9 to 2.0.11 by [@​dependabot](https://github.com/dependabot) in Automattic/harper#369 - feat: Typst Language Support by [@​grantlemons](https://github.com/grantlemons) in Automattic/harper#302 - build(deps): bump serde_json from 1.0.134 to 1.0.135 by [@​dependabot](https://github.com/dependabot) in Automattic/harper#368 - feat(core): create new linter for dollar sign placement by [@​elijah-potter](https://github.com/elijah-potter) in Automattic/harper#376 - refactor: Harper-ls Error-Handling Improvements by [@​grantlemons](https://github.com/grantlemons) in Automattic/harper#349 - feat([#​104](Automattic/harper#104)): Markdown linter config for ignoring link titles by [@​grantlemons](https://github.com/grantlemons) in Automattic/harper#305 - feat(harper.js): added ability to configure the markup language by [@​elijah-potter](https://github.com/elijah-potter) in Automattic/harper#379 - feat(vscode-plugin): Add Literate Haskell and Typst Support + some doc updates by [@​mcecode](https://github.com/mcecode) in Automattic/harper#388 #### New Contributors - [@​wadsaek](https://github.com/wadsaek) made their first contribution in Automattic/harper#367 - [@​elijah-potter](https://github.com/elijah-potter) made their first contribution in Automattic/harper#361 - [@​zamazan4ik](https://github.com/zamazan4ik) made their first contribution in Automattic/harper#363 **Full Changelog**: Automattic/harper@v0.15.0...v0.16.0 ### [`v0.15.0`](https://github.com/Automattic/harper/releases/tag/v0.15.0) [Compare Source](Automattic/harper@v0.14.0...v0.15.0) #### What's Changed - Added a variety of rules (see [complete list here](https://writewithharper.com/docs/rules)). - Fixed issues with parsing hostnames - Added a variety of available `Pattern`s for downstream use - Update +page.md by [@​aminwhat](https://github.com/aminwhat) in Automattic/harper#347 - feat: Add technical words to dictionary by [@​claydugo](https://github.com/claydugo) in Automattic/harper#343 - refactor: remove raw hashes that are unnecessary by [@​hamirmahal](https://github.com/hamirmahal) in Automattic/harper#324 - feat: Span View Command Improvements by [@​grantlemons](https://github.com/grantlemons) in Automattic/harper#340 - Address "one" for indefinite article rule by [@​claydugo](https://github.com/claydugo) in Automattic/harper#359 - feat: Add support for cmake files by [@​alcroito](https://github.com/alcroito) in Automattic/harper#353 - build(deps): bump itertools from 0.13.0 to 0.14.0 by [@​dependabot](https://github.com/dependabot) in Automattic/harper#357 - feat(harper-ls): remove deleted file/s diagnostics by [@​mcecode](https://github.com/mcecode) in Automattic/harper#304 - feat(vscode-plugin): Add CMake Support by [@​mcecode](https://github.com/mcecode) in Automattic/harper#360 #### New Contributors - [@​aminwhat](https://github.com/aminwhat) made their first contribution in Automattic/harper#347 - [@​hamirmahal](https://github.com/hamirmahal) made their first contribution in Automattic/harper#324 - [@​alcroito](https://github.com/alcroito) made their first contribution in Automattic/harper#353 **Full Changelog**: Automattic/harper@v0.14.0...v0.15.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS45My4wIiwidXBkYXRlZEluVmVyIjoiMzkuMTA3LjAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbIlJlbm92YXRlIEJvdCJdfQ==-->
|
Adverbs can also follow "the" because they can modify adjectives: "The extremely fat man". Also don't forget that verbs behave as nouns in their gerund form and as adjectives in their present participle form, both of which share the -ing inflection: "The running of the bull", "The running man". |
|
To me a counterexample is "He is 7 foot tall so he's the only one I'm shorter than". But even though it sounds right to my native-speaker intuition, I went ahead and asked on my usual English forum: Is it correct to end a sentence with "than"? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Consider the sentence:
Harper currently does not find anything wrong with this sentence.
Yet, the word "than" must be followed by a word, and the word "the" must be followed by an adjective or a noun (I believe).
It would be cool if Harper could diagnose these mistakes.
The text was updated successfully, but these errors were encountered: