Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug on node iterator with nested nodes #7

Closed
LucasXu0 opened this issue Mar 15, 2023 · 0 comments
Closed

bug on node iterator with nested nodes #7

LucasXu0 opened this issue Mar 15, 2023 · 0 comments

Comments

@LucasXu0
Copy link
Collaborator

When we have more than two level nodes nested (as children) the node iterator misses the first parent, because it goes as deep as possible at first.

Faced this while working on Table.

Reference: AppFlowy-IO/AppFlowy#1986
@LucasXu0 LucasXu0 changed the title fix: bug on node iterator with nested nodes bug on node iterator with nested nodes Mar 15, 2023
@LucasXu0 LucasXu0 mentioned this issue Mar 15, 2023
Merged
LucasXu0 added a commit that referenced this issue Mar 15, 2023
@LucasXu0
Merge pull request #11 from LucasXu0/fix_#7
c79d9a9 
fix: #7 bug on node iterator with nested nodes
@forrestsocool forrestsocool mentioned this issue Apr 13, 2023
Closed
This was referenced Jun 21, 2023
Closed
Closed
@q200892907 q200892907 mentioned this issue Jul 25, 2023
Closed
@sun-jiao sun-jiao mentioned this issue Sep 14, 2023
Closed
@q200892907 q200892907 mentioned this issue Nov 7, 2023
Closed
@Mikhail-Ivanou Mikhail-Ivanou mentioned this issue Dec 26, 2023
Open
@mikivanou mikivanou mentioned this issue Jan 4, 2024
Open
This was referenced Feb 21, 2024
Closed
Closed
@Xazin Xazin mentioned this issue Apr 17, 2024
Open
@q200892907 q200892907 mentioned this issue Sep 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LucasXu0