Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bug on node iterator with nested nodes #1986

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

zoli
Copy link
Contributor

@zoli zoli commented Mar 13, 2023

When we have more than two level nodes nested (as children) the node iterator misses the first parent, because it goes as deep as possible at first.

Faced this while working on Table.

When we have more than two level nodes nested (as children)
the node iterator misses the first parent, because it goes as
deep as possible at first.
@AppFlowy-IO AppFlowy-IO deleted a comment from codecov bot Mar 14, 2023
@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Merging #1986 (298f694) into main (79a43de) will decrease coverage by 0.02%.
The diff coverage is 4.39%.

❗ Current head 298f694 differs from pull request most recent head 875c87e. Consider uploading reports for the commit 875c87e to get more accurate results

@@            Coverage Diff             @@
##             main    #1986      +/-   ##
==========================================
- Coverage   15.89%   15.88%   -0.02%     
==========================================
  Files         316      316              
  Lines       14055    14072      +17     
==========================================
+ Hits         2234     2235       +1     
- Misses      11821    11837      +16     
Flag Coverage Δ
appflowy 15.88% <4.39%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...database_view/application/database_controller.dart 0.00% <0.00%> (ø)
...tabase_view/application/database_view_service.dart 0.00% <0.00%> (ø)
...abase_view/application/field/field_controller.dart 0.00% <0.00%> (ø)
...resentation/plugins/base/built_in_page_widget.dart 0.00% <0.00%> (ø)
...presentation/plugins/base/link_to_page_widget.dart 0.00% <0.00%> (ø)
...esentation/plugins/cover/change_cover_popover.dart 0.00% <0.00%> (ø)
...tion/plugins/openai/widgets/smart_edit_action.dart 0.00% <ø> (ø)
...plugins/openai/widgets/smart_edit_node_widget.dart 0.00% <0.00%> (ø)
...lugins/openai/widgets/smart_edit_toolbar_item.dart 1.81% <0.00%> (+1.81%) ⬆️
...ter/lib/workspace/application/app/app_service.dart 8.47% <ø> (ø)
... and 4 more

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@LucasXu0 LucasXu0 merged commit 7be7c2a into AppFlowy-IO:main Mar 14, 2023
@zoli zoli deleted the fix/node-iterator branch March 15, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants