Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Korean language support issue #231

Closed
voisbe opened this issue Jun 21, 2023 · 8 comments · Fixed by #255
Closed

[Bug] Korean language support issue #231

voisbe opened this issue Jun 21, 2023 · 8 comments · Fixed by #255
Assignees

Comments

@voisbe
Copy link

voisbe commented Jun 21, 2023

Bug Description

When I change the keyboard to Korean language and type, I get an error.

Unhandled Exception: FormatException

#0 _extension#8.shift (package:appflowy_editor/src/editor/editor_component/service/ime/delta_input_service.dart:311:7)
#1 _extension#8.<< (package:appflowy_editor/src/editor/editor_component/service/ime/delta_input_service.dart:308:42)
#2 _extension#2.format (package:appflowy_editor/src/editor/editor_component/service/ime/delta_input_service.dart:252:26)
#3 _extension#1.format (package:appflowy_editor/src/editor/editor_component/service/ime/delta_input_service.dart:238:50)
#4 DeltaTextInputService.apply. (package:appflowy_editor/src/editor/editor_component/service/ime/delta_input_service.dart:68:49)
#5 MappedListIterable.elementAt (dart:_internal/iterable.dart:415:31)
#6 ListIterator.moveNext (dart:_internal/iterable.dart:344:26)
#7 new _GrowableList._ofEfficientLengthIterable (dart:core-patch/growable_array.dart:189:27)
#8 new _GrowableList.of (dart:core-patch/growable_array.dart:150:28)
#9 new List.of (dart:core-patch/array_patch.dart:47:28)
#10 ListIterable.toList (dart:_internal/iterable.dart:214:7)
#11 DeltaTextInputService.apply (package:appflowy_editor/src/editor/editor_component/service/ime/delta_input_service.dart:68:59)
#12 DeltaTextInputService.updateEditingValueWithDeltas (package:appflowy_editor/src/editor/editor_component/service/ime/delta_input_service.dart:121:5)
#13 TextInput._handleTextInputInvocation (package:flutter/src/services/text_input.dart:1857:63)
#14 TextInput._loudlyHandleTextInputInvocation (package:flutter/src/services/text_input.dart:1746:20)
#15 MethodChannel._handleAsMethodCall (package:flutter/src/services/platform_channel.dart:547:55)
#16 MethodChannel.setMethodCallHandler. (package:flutter/src/services/platform_channel.dart:540:34)
#17 _DefaultBinaryMessenger.setMessageHandler. (package:flutter/src/services/binding.dart:567:35)
#18 _invoke2 (dart:ui/hooks.dart:202:13)
#19 _ChannelCallbackRecord.invoke (dart:ui/channel_buffers.dart:40:5)
#20 _Channel.push (dart:ui/channel_buffers.dart:130:31)
#21 ChannelBuffers.push (dart:ui/channel_buffers.dart:326:17)
#22 PlatformDispatcher._dispatchPlatformMessage (dart:ui/platform_dispatcher.dart:723:22)
#23 _dispatchPlatformMessage (dart:ui/hooks.dart:114:31)

How to Reproduce

Change your keyboard to Korean language and type.
"안녕하세요."

Expected Behavior

Korean input should come out properly.
ex) 안녕하세요.

Operating System

MacOS, iOS

AppFlowy Editor Version(s)

1.0.4

Screenshots

  1. Typing Korean language in the appflowy official desktop app works fine.
스크린샷 2023-06-21 오후 8 00 06
  1. The mentioned error occurs in the app I am implementing or in the provided sample app. An error occurs and the characters come out garbled.
스크린샷 2023-06-21 오후 8 22 29 스크린샷 2023-06-21 오후 8 22 57

Additional Context

No response

@LucasXu0
Copy link
Collaborator

@voisbe Does it work as expected on the macOS?

@voisbe
Copy link
Author

voisbe commented Jun 22, 2023

@LucasXu0 Yes, both the official and sample apps for MacOS desktop work well.
스크린샷 2023-06-22 오후 2 34 24

@LucasXu0
Copy link
Collaborator

@voisbe Is it what you want? I'm not sure because I don't understand the Korean input method.

vv.mp4

Or could you help to check this PR? #253

@voisbe
Copy link
Author

voisbe commented Jun 25, 2023

@LucasXu0 The issue is not resolved. Entering text with autocomplete works well, but the problem arises when typing manually character by character. I'm not very familiar with it, but I'll take a closer look at the code.

@voisbe
Copy link
Author

voisbe commented Jun 26, 2023

@LucasXu0 No FormatException errors occur. However, there remains a problem with the characteristics of Hangul. Up to 3 characters are combined in Hangeul. Up to 2 characters are combined, but 3 characters are not created.
ex) 안녕 (o) 아ㄴ녀ㅇ (x)

스크린샷 2023-06-26 오후 1 26 12
RPReplay_Final1687752839.MP4
  • TextField

@LucasXu0
Copy link
Collaborator

@voisbe Got it.

@LucasXu0 LucasXu0 self-assigned this Jun 26, 2023
@LucasXu0
Copy link
Collaborator

@voisbe #255

Can you help to check the latest code? I tested with Korean IME, it works fine now.

@voisbe
Copy link
Author

voisbe commented Jun 26, 2023

@LucasXu0 It works. Great job! It's much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants