Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support static code anslysis with githook and local lint check #411

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Support static code anslysis with githook and local lint check #411

merged 1 commit into from
Nov 3, 2023

Conversation

tuancoltech
Copy link
Collaborator

@tuancoltech tuancoltech commented Oct 31, 2023 •
edited
Loading

🚀 Summary

  • Run ktlintCheck on every commit using git hooks.
  • Support running ktlinCheck locally by triggering it before every ./gradlew build or ./gradlew check command for local lint analysis.

Related issues:
#409
#402

@tuancoltech tuancoltech temporarily deployed to Development October 31, 2023 15:56 — with GitHub Actions Inactive
@tuancoltech tuancoltech changed the title Test/githook ktlint check Support static code anslysis with githook and locale lint check Oct 31, 2023
@tuancoltech tuancoltech changed the title Support static code anslysis with githook and locale lint check Support static code anslysis with githook and local lint check Oct 31, 2023
@tuancoltech tuancoltech temporarily deployed to Development October 31, 2023 16:04 — with GitHub Actions Inactive
@tuancoltech tuancoltech force-pushed the test/githook_ktlint_check branch from ddf79e5 to 5496970 Compare October 31, 2023 16:05
@tuancoltech tuancoltech temporarily deployed to Development October 31, 2023 16:05 — with GitHub Actions Inactive
@tuancoltech tuancoltech force-pushed the test/githook_ktlint_check branch from 5496970 to 04f2ede Compare October 31, 2023 16:07
@tuancoltech tuancoltech temporarily deployed to Development October 31, 2023 16:07 — with GitHub Actions Inactive
@tuancoltech tuancoltech force-pushed the test/githook_ktlint_check branch from 04f2ede to aadd7e6 Compare October 31, 2023 16:09
@tuancoltech tuancoltech temporarily deployed to Development October 31, 2023 16:09 — with GitHub Actions Inactive
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@tuancoltech tuancoltech temporarily deployed to Development October 31, 2023 16:17 — with GitHub Actions Inactive
@tuancoltech tuancoltech temporarily deployed to Development October 31, 2023 16:21 — with GitHub Actions Inactive
kirillt
kirillt approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@kirillt kirillt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@kirillt kirillt merged commit 0782211 into main Nov 3, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirillt kirillt kirillt approved these changes

@hieuwu hieuwu Awaiting requested review from hieuwu

@mdrlzy mdrlzy Awaiting requested review from mdrlzy

@shubertm shubertm Awaiting requested review from shubertm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tuancoltech @kirillt