[enhancement] Fix Lint warnings including: * Unused namespaces in XML…

… * Add task configuration avoidance by using register when define a gradle task * Update protected visibility in final class to private as they are effectively the same * Add private modifier for variables where needed * Upgrade kotlin version & kotlin gradle plugin to 1.8.20 * Naming issues and others

[lint] Execute ktlintCheck prior to every git commit to scan for lint errors

app/app-scripts/pre-commit

@@ -0,0 +1,19 @@
+#!/bin/bash
+echo "*********************************************************"
+echo "Running git pre-commit hook, ktlintCheck in progress..."
+echo "*********************************************************"
+
+./gradlew ktlintCheck
+
+status=$?
+
+if [ "$status" = 0 ] ; then
+    echo "Static analysis found no problems."
+    exit 0
+else
+    echo "*********************************************************"
+    echo 1>&2 "ktlintCheck found violations it could not fix."
+    echo "Run ./gradlew ktlintFormat to fix formatting related issues..."
+    echo "*********************************************************"
+    exit 1
+fi

app/build.gradle

@@ -198,3 +198,5 @@ tasks.register('installGitHook', Copy) {
     rename("pre-commit-$suffix", 'pre-commit')
     fileMode 0775
 }
+
+build.dependsOn installGitHook

app/src/main/java/dev/arkbuilders/navigator/presentation/screen/folders/FoldersViewModel.kt

@@ -23,13 +23,14 @@ import org.orbitmvi.orbit.syntax.simple.postSideEffect
 import org.orbitmvi.orbit.syntax.simple.reduce
 import org.orbitmvi.orbit.viewmodel.container
 import java.nio.file.Path
+import android.view.View
 
 class ProgressWithText(val enabled: Boolean, val text: String = "")
 
 data class FoldersState private constructor(
     val devices: List<Path>,
     val folders: Map<Path, List<Path>>,
-    val progressWithText: ProgressWithText
+    val progressWithText: ProgressWithText,
 ) {
     companion object {
         fun initial() =
@@ -52,7 +53,7 @@ class FoldersViewModel(
     private val resourcesIndexRepo: ResourceIndexRepo,
     private val preferences: Preferences,
     private val permsHelper: PermissionsHelper,
-    private val devicePathsExtractor: DevicePathsExtractor
+    private val devicePathsExtractor: DevicePathsExtractor,
 ) : ViewModel(), ContainerHost<FoldersState, FoldersSideEffect> {
 
     override val container: Container<FoldersState, FoldersSideEffect> = container(
@@ -139,7 +140,7 @@ class FoldersViewModel(
     fun onForgetFavorite(
         root: Path,
         favorite: Path,
-        deleteFromMemory: Boolean
+        deleteFromMemory: Boolean,
     ) = intent {
         reduce {
             state.copy(
@@ -287,7 +288,7 @@ class FoldersViewModelFactory @AssistedInject constructor(
     private val resourcesIndexRepo: ResourceIndexRepo,
     private val preferences: Preferences,
     private val permsHelper: PermissionsHelper,
-    private val devicePathsExtractor: DevicePathsExtractor
+    private val devicePathsExtractor: DevicePathsExtractor,
 ) : ViewModelProvider.Factory {
     override fun <T : ViewModel> create(modelClass: Class<T>): T {
         return FoldersViewModel(
@@ -303,7 +304,7 @@ class FoldersViewModelFactory @AssistedInject constructor(
     @AssistedFactory
     interface Factory {
         fun create(
-            @Assisted rescanRoots: Boolean
+            @Assisted rescanRoots: Boolean,
         ): FoldersViewModelFactory
     }
 }