[enhancement] Fix Lint warnings including: * Unused namespaces in XML…

… * Add task configuration avoidance by using register when define a gradle task * Update protected visibility in final class to private as they are effectively the same * Add private modifier for variables where needed * Upgrade kotlin version & kotlin gradle plugin to 1.8.20 * Naming issues and others

[lint] Execute ktlintCheck prior to every git commit to scan for lint errors

.editorconfig

@@ -5,6 +5,7 @@
 root = true
 
 
+# noinspection EditorConfigKeyCorrectness
 [*]
 
 indent_style = space

app/app-scripts/pre-commit

@@ -0,0 +1,19 @@
+#!/bin/bash
+echo "*********************************************************"
+echo "Running git pre-commit hook, ktlintCheck in progress..."
+echo "*********************************************************"
+
+./gradlew ktlintCheck
+
+status=$?
+
+if [ "$status" = 0 ] ; then
+    echo "Static analysis found no problems."
+    exit 0
+else
+    echo "*********************************************************"
+    echo 1>&2 "ktlintCheck found violations it could not fix."
+    echo "Run ./gradlew ktlintFormat to fix formatting related issues..."
+    echo "*********************************************************"
+    exit 1
+fi

app/build.gradle

@@ -187,7 +187,7 @@ dependencies {
     implementation 'com.airbnb.android:lottie:6.1.0'
 }
 
-task installGitHook(type: Copy) {
+tasks.register('installGitHook', Copy) {
     def suffix = "linux"
     if (Os.isFamily(Os.FAMILY_WINDOWS)) {
         suffix = "windows"
@@ -197,3 +197,5 @@ task installGitHook(type: Copy) {
     rename("pre-commit-$suffix", 'pre-commit')
     fileMode 0775
 }
+
+build.dependsOn installGitHook

app/src/main/java/dev/arkbuilders/navigator/data/PermissionsHelper.kt

@@ -26,17 +26,17 @@ import javax.inject.Singleton
 
 @Singleton
 class PermissionsHelper @Inject constructor(private val appContext: Context) {
-    val permissionResultFlow = MutableSharedFlow<Boolean>()
+    private val permissionResultFlow = MutableSharedFlow<Boolean>()
     private var writePermLauncher: ActivityResultLauncher<String>? = null
     private var writePermUsingSettingsLauncher: ActivityResultLauncher<String>? =
         null
-    private var writePermLauncher_R: ActivityResultLauncher<String>? = null
+    private var writePermLauncherR: ActivityResultLauncher<String>? = null
 
     fun registerActivity(activity: AppCompatActivity) {
         writePermLauncher = buildWritePermLauncher(activity)
         writePermUsingSettingsLauncher =
             buildWritePermsUsingSettingsLauncher(activity)
-        writePermLauncher_R = buildWritePermLauncher_R(activity)
+        writePermLauncherR = buildWritePermLauncherR(activity)
     }
 
     fun isWritePermissionGranted(): Boolean {
@@ -56,7 +56,7 @@ class PermissionsHelper @Inject constructor(private val appContext: Context) {
     ) {
         val packageUri = "package:" + BuildConfig.APPLICATION_ID
         if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.R) {
-            writePermLauncher_R!!.launch(packageUri)
+            writePermLauncherR!!.launch(packageUri)
         } else {
             val rationale =
                 fragment?.shouldShowRequestPermissionRationale(
@@ -120,7 +120,7 @@ class PermissionsHelper @Inject constructor(private val appContext: Context) {
             }
         }
 
-    private fun buildWritePermLauncher_R(
+    private fun buildWritePermLauncherR(
         activity: AppCompatActivity
     ) =
         activity.registerForActivityResult(

app/src/main/java/dev/arkbuilders/navigator/data/stats/AggregatedStatsStorage.kt

@@ -7,7 +7,7 @@ import kotlinx.coroutines.withContext
 import dev.arkbuilders.arklib.data.stats.StatsEvent
 import dev.arkbuilders.arklib.user.tags.Tag
 
-class AggregatedStatsStorage(val shards: List<StatsStorage>) : StatsStorage {
+class AggregatedStatsStorage(private val shards: List<StatsStorage>) : StatsStorage {
 
     override suspend fun init() = withContext(Dispatchers.IO) {
         shards.map { launch { it.init() } }.joinAll()

app/src/main/java/dev/arkbuilders/navigator/data/stats/PlainStatsStorage.kt

@@ -27,7 +27,7 @@ class PlainStatsStorage(
     private val index: RootIndex,
     private val preferences: Preferences,
     private val tagStorage: RootTagsStorage,
-    private val statsFlow: SharedFlow<StatsEvent>
+    statsFlow: SharedFlow<StatsEvent>
 ) : StatsStorage {
 
     private val root = index.path

app/src/main/java/dev/arkbuilders/navigator/data/stats/StatsStorageRepo.kt

@@ -33,7 +33,7 @@ class StatsStorageRepo(
         }
     }
 
-    suspend fun provide(
+    private suspend fun provide(
         root: RootIndex,
         tagsStorage: RootTagsStorage
     ): PlainStatsStorage =

app/src/main/java/dev/arkbuilders/navigator/data/stats/category/StatsCategoryStorage.kt

@@ -16,7 +16,7 @@ private const val FLUSH_INTERVAL = 10_000L
 
 abstract class StatsCategoryStorage<out T>(
     val root: Path,
-    val scope: CoroutineScope
+    private val scope: CoroutineScope
 ) {
     abstract val fileName: String
     private val flushFlow = MutableSharedFlow<Unit>().also { flow ->
@@ -36,7 +36,7 @@ abstract class StatsCategoryStorage<out T>(
     abstract fun provideData(): T
     protected abstract fun flush()
 
-    fun locateStorage() = root.arkFolder().arkStats().resolve(fileName)
+    fun locateStorage(): Path? = root.arkFolder().arkStats().resolve(fileName)
 
     protected fun requestFlush() = scope.launch {
         flushFlow.emit(Unit)

app/src/main/java/dev/arkbuilders/navigator/data/stats/category/TagLabeledNStorage.kt

@@ -17,7 +17,7 @@ import kotlin.io.path.writeText
 
 class TagLabeledNStorage(
     val index: ResourceIndex,
-    val tagsStorage: TagStorage,
+    private val tagsStorage: TagStorage,
     root: Path,
     scope: CoroutineScope
 ) : StatsCategoryStorage<Map<Tag, Int>>(root, scope) {
@@ -26,7 +26,7 @@ class TagLabeledNStorage(
 
     override suspend fun init() {
         val storage = locateStorage()
-        if (storage.exists()) {
+        if (storage?.exists() == true) {
             val json = Json.decodeFromStream<JsonTagLabeledN>(storage.inputStream())
             tagLabeledAmount.putAll(json.data)
         } else {
@@ -64,7 +64,7 @@ class TagLabeledNStorage(
 
     override fun flush() {
         val data = Json.encodeToString(JsonTagLabeledN(tagLabeledAmount))
-        locateStorage().writeText(data)
+        locateStorage()?.writeText(data)
         Timber.i("flushed with $tagLabeledAmount")
     }
 }

app/src/main/java/dev/arkbuilders/navigator/data/stats/category/TagLabeledTSStorage.kt

@@ -47,7 +47,7 @@ class TagLabeledTSStorage(
 
     override fun flush() {
         val data = Json.encodeToString(JsonTagLabeledTS(tagLabeledTS))
-        locateStorage().writeText(data)
+        locateStorage()?.writeText(data)
         Timber.i("flushed with $tagLabeledTS")
     }
 }

app/src/main/java/dev/arkbuilders/navigator/data/stats/category/TagQueriedNStorage.kt

@@ -48,7 +48,7 @@ class TagQueriedNStorage(
 
     override fun flush() {
         val data = Json.encodeToString(JsonTagQueriedN(tagQueriedN))
-        locateStorage().writeText(data)
+        locateStorage()?.writeText(data)
         Timber.i("flushed with $tagQueriedN")
     }
 }

app/src/main/java/dev/arkbuilders/navigator/data/stats/category/TagQueriedTSStorage.kt

@@ -22,9 +22,11 @@ class TagQueriedTSStorage(
 
     override suspend fun init() {
         val storage = locateStorage()
-        if (storage.notExists()) return
-        val json = Json.decodeFromStream<JsonTagQueriedTS>(storage.inputStream())
-        tagQueriedTS.putAll(json.data)
+        if (storage?.notExists() == true) return
+        val json = storage?.let {
+            Json.decodeFromStream<JsonTagQueriedTS>(it.inputStream())
+        }
+        json?.let { tagQueriedTS.putAll(it.data) }
         Timber.i("initialized with $tagQueriedTS")
     }
 
@@ -43,7 +45,7 @@ class TagQueriedTSStorage(
 
     override fun flush() {
         val data = Json.encodeToString(JsonTagQueriedTS(tagQueriedTS))
-        locateStorage().writeText(data)
+        locateStorage()?.writeText(data)
         Timber.i("flushed with $tagQueriedTS")
     }
 }

app/src/main/java/dev/arkbuilders/navigator/presentation/dialog/RootPickerDialogFragment.kt

@@ -19,7 +19,7 @@ class RootPickerDialogFragment : ArkFilePickerFragment() {
     @Inject
     lateinit var foldersRepo: FoldersRepo
 
-    var rootNotFavorite = false
+    private var rootNotFavorite = false
 
     override fun onAttach(context: Context) {
         App.instance.appComponent.inject(this)

app/src/main/java/dev/arkbuilders/navigator/presentation/dialog/tagssort/TagsSortViewModel.kt

@@ -34,7 +34,7 @@ sealed class TagsSortSideEffect {
 }
 
 class TagsSortViewModel(
-    private val selectorNotEdit: Boolean,
+    selectorNotEdit: Boolean,
     private val preferences: Preferences
 ) : ViewModel(), ContainerHost<TagsSortState, TagsSortSideEffect> {
     override val container: Container<TagsSortState, TagsSortSideEffect> =