Bug-fix: Add range checking for parameters in MetricsReportingConfiguration #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-shared as it is potentially shared between rt-5gms-application-function and rt-5gms-application-provider
This was referenced Mar 19, 2024
This was
linked to
issues
Mar 19, 2024
rjb1000
approved these changes
Mar 19, 2024
There was a problem hiding this comment.
Looks good, @davidjwbbc.
But let's get @stojkovicv's review too before merging.
stojkovicv
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supercedes #147 by performing range checking for the M1 metrics reporting parameters in autogenerated code (based on modified YAML) rather than explicitly in 5GMS AF code.
This also moves the
TS26512_M1_MetricsReportingProvisioning.yamloverride file back into the rt-common-shared repository (see 5G-MAG/rt-common-shared#36 for counterpart PR) as it is potentially shared between this repository and rt-5gms-application-provider.