Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QoE Metrics Reporting - M1 Provisioning - samplingPeriod can be negative #146

Closed
dsilhavy opened this issue Mar 15, 2024 · 4 comments · Fixed by #148
Closed

QoE Metrics Reporting - M1 Provisioning - samplingPeriod can be negative #146

dsilhavy opened this issue Mar 15, 2024 · 4 comments · Fixed by #148
Assignees
Milestone

Comments

@dsilhavy
Copy link
Contributor

Description

TS 26.512 Table 7.8.3-1 defines the samplingPeriod as follows:

The time interval the 5GMS Client should wait between sampling the QoE metrics specified by this metrics reporting configuration.

In my opinion, a negative value does not make sense here, although it is not explicitly mentioned in the specification. However, the type of the samplingPeriod is DurationSec which is defined in TS29571_CommonData as :

    DurationSec:
      type: integer
      description: indicating a time in seconds.

A negative time in seconds seems to be unreasonable. I suggest to return an error in case a negative value for samplingPeriod is provided.

@dsilhavy
Copy link
Contributor Author

dsilhavy commented Mar 15, 2024

@rjb1000 Any opinion on this? Should DurationSec be UInt?

@rjb1000
Copy link
Contributor

rjb1000 commented Mar 15, 2024

Quite possibly, @dsilhavy .

But note that TS 29.571 is a specification under CT control, and so more difficult to "fix".

An alternative solution might be to switch to the Duration data type defined in the common data types for TS 26.512 (and, in Rel-18, ported to TS 26.510). This uses the string-based representation specified in ISO 8601 and RFC 3339 instead of an integer.

@rjb1000
Copy link
Contributor

rjb1000 commented Mar 15, 2024

See also #145.

@dsilhavy
Copy link
Contributor Author

Confirmed this is fixed with the latest changes

@dsilhavy dsilhavy added this to the Version 1.4.1 milestone Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment