-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QoE Metrics Reporting - M1 Provisioning - samplingPeriod can be negative #146
Comments
@rjb1000 Any opinion on this? Should |
Quite possibly, @dsilhavy . But note that TS 29.571 is a specification under CT control, and so more difficult to "fix". An alternative solution might be to switch to the Duration data type defined in the common data types for TS 26.512 (and, in Rel-18, ported to TS 26.510). This uses the string-based representation specified in ISO 8601 and RFC 3339 instead of an integer. |
See also #145. |
Confirmed this is fixed with the latest changes |
Description
TS 26.512 Table 7.8.3-1 defines the
samplingPeriod
as follows:In my opinion, a negative value does not make sense here, although it is not explicitly mentioned in the specification. However, the type of the
samplingPeriod
isDurationSec
which is defined in TS29571_CommonData as :A negative time in seconds seems to be unreasonable. I suggest to return an error in case a negative value for
samplingPeriod
is provided.The text was updated successfully, but these errors were encountered: