Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QoE Metrics Reporting - M1 Provisioning - reportingInterval shall be greater than zero #145

Closed
dsilhavy opened this issue Mar 15, 2024 · 3 comments · Fixed by #148
Closed
Assignees
Labels
bug Something isn't working
Milestone

Comments

@dsilhavy
Copy link
Contributor

Description

According to TS 26.512 Table 7.8.3-1 the reportingInterval shall be greater than zero:

The time interval between successive metrics reports. The value shall be greater than zero.
If not specified, a single final report shall be sent after the media streaming session has ended.

The current implementation accepts values equal and below zero. Resulting output when reading the configuration afterwards

{
    "reportingInterval": -1,
}
@rjb1000
Copy link
Contributor

rjb1000 commented Mar 15, 2024

Looks like this will need to be validated manually (at least for the time being) since the underlying YAML data type for DurationSec is a signed integer without a sensible minimum value of 0.

@rjb1000
Copy link
Contributor

rjb1000 commented Mar 15, 2024

See also #146.

@dsilhavy
Copy link
Contributor Author

Confirmed this is fixed with the latest changes

@dsilhavy dsilhavy added this to the Version 1.4.1 milestone Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
4 participants