-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reserve resource ID for schemes #182
Comments
Oh, thank you. Would it be better to use IDs higher than 63100?
|
values larger than 63100 already used by styles (in EditLexers\EditStyle.h). Change resource ids for styles is easy, it will not breaking end users. When we are going to support 100 schemes, resource ids for styles can be increased by 100 with a simple regex replace in EditStyle.h; at that time |
Added these IDs in 61a4158, only 22 unused now, though I think it still need several years to use all of them. |
Thank you so much. 👍 |
Resource id for styles are increased by 100 in 20e94a3, values in [63000, 63200] can be used as resource id for schemes. |
…od and Korean version, issue zufuliu#182.
…the further, issue zufuliu#182.
Hi @bluenlive, sorry for the inconvenience, but I had renamed these IDs (both |
Closed this issue, since commit e373f9a, resource id for scheme can be any number (except that |
Since v4.20.04, resource ids for lexers/schemes are saved in default scheme and favorite schemes preferences to replaced the unstable lexer index. for compatibility reason, it's better to reserved these ids already used by existing forks/modifications.
@bluenlive do you have other schemes? it's even better if you already have these ids (in [63000, 63100], but not used in EditLexer.h).
The text was updated successfully, but these errors were encountered: