Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Canonicalize option settings earlier #536

Open
danielshahaf opened this issue Sep 22, 2018 · 3 comments
Open

Canonicalize option settings earlier #536

danielshahaf opened this issue Sep 22, 2018 · 3 comments
Labels
Task
Milestone
0.8.1

Comments

@danielshahaf
Copy link
Member

#535 / 3a7ddcd was a bug due to _zsh_highlight_load_highlighters running with the interactive environment's options. We already call emulate -L in _zsh_highlight for precisely this reason.

Long-term we should switch to an autoload design (#252), but in the interim, we should review the driver to see if we can either:

  • Run more of the driver's code under canonicalized option settings; or
  • Review the driver's code to see if it's robust for being run under arbitrary setopt's (particularly including those that change syntax)
@danielshahaf
Copy link
Member Author

Cross-referencing #688.

@danielshahaf danielshahaf added this to the 0.8.0 milestone Mar 17, 2020
@danielshahaf
Copy link
Member Author

Triage: not a blocker; depends on #252/#688 which depend on redrawhook which depends on zsh-users/zsh#57; so: deferring to 0.9.0 and labeling so that once redrawhook is merged we'll re-triage this.

@danielshahaf danielshahaf modified the milestones: 0.8.0, 0.9.0 May 22, 2020
This was referenced Jul 12, 2020
Open
Merged
@danielshahaf
Copy link
Member Author

Re-triaged. The dependencies #252/#688 are milestone 0.9.0, therefore so is this issue. Removing the temporary label (see previous comment).

danielshahaf added a commit that referenced this issue Aug 9, 2020
@danielshahaf
empty commit: Close redrawhook bugs
c14fcad 
The parent commit, which merged the feature/redrawhook bug and thereby
closed PR #749, also fixed the following issue:

Fixes #40.

Fixes #90, closes #470. (The latter is a PR for the former.)

Fixes #150, closes #151, closes #160. (The latter two are PR's for the first one.) The related issue #183 appears to have been fixed in master. For #150, a different fix for older versions of zsh was considered but has not been implemented.

Issue #154 was fixed in xsel(1) in 2017. The parent commit probably fixed that issue for pre-2017 xsel(1).

Is #245, #356, and #749. Fixes #245 (redrawhook umbrella issue).

Does not reintroduce #257 (comment).

Does not reintroduce #259 (comment)

Closes #281 as obsolete.

Fixes #295.

Fixes #324.

Fixes #375.

Fixes #377.

Closes #421 as obsolete.

Fixes #520.

Unblocks #536 (already milestoned).

Fixes #632.

Unblocks #635. Milestoned.

Unblocks #688. Milestoned.

Unblocks administrative issue #655 (already milestoned).

(The above is copied from
#749 (comment),
but repeated here for the sake of github's commit-to-issue linking magic.)
@phy1729 phy1729 mentioned this issue Aug 10, 2020
Open
@danielshahaf danielshahaf modified the milestones: 0.9.0, 0.8.0 Aug 11, 2020
@phy1729 phy1729 modified the milestones: 0.8.0, 0.8.1 Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Task
Projects
None yet
Milestone
0.8.1
Development

No branches or pull requests
2 participants
@phy1729 @danielshahaf