Unsuccessful completion removes highlighting

[hedning]

If completion returns an error all highlighting will be removed.
Eg. failed file expansion cat filethatdoesntexist<tab>

This patch fixes it:

diff --git a/zsh-syntax-highlighting.zsh b/zsh-syntax-highlighting.zsh
index cbd63e9..4ad0106 100644
--- a/zsh-syntax-highlighting.zsh
+++ b/zsh-syntax-highlighting.zsh
@@ -105,9 +105,12 @@ typeset -gA ZSH_HIGHLIGHT_STYLES
 # Whether the command line buffer has been modified or not.
 #
 # Returns 0 if the buffer has changed since _zsh_highlight was last called.
+# This doesn't work reliably. As the buffer might be modified, but without
+# changing the text content. Eg. when file expansion fail when
+# autocompelting.
 _zsh_highlight_buffer_modified()
 {
-  [[ "${_ZSH_HIGHLIGHT_PRIOR_BUFFER:-}" != "$BUFFER" ]]
+  true
 }

 # Whether the cursor has moved or not.
@@ -147,7 +150,7 @@ _zsh_highlight_bind_widgets()

       # Completion widget: override and rebind old one with prefix "orig-".
       completion:*) eval "zle -C orig-$cur_widget ${${widgets[$cur_widget]#*:}/:/ }; \
-                          _zsh_highlight_widget_$cur_widget() { builtin zle orig-$cur_widget -- \"\$@\" && _zsh_highlight }; \
+                          _zsh_highlight_widget_$cur_widget() { { builtin zle orig-$cur_widget -- \"\$@\"; } always { _zsh_highlight; } }; \
                           zle -N $cur_widget _zsh_highlight_widget_$cur_widget";;

       # Builtin widget: override and make it call the builtin ".widget".

[nicoulaj]

This fix is not OK, this will trigger highlighting a lot more often and make the whole shell even more slower...

[hedning]

Might be. Haven't seen any major slowdowns, but obvisously not ideal.

On Mon, 13 Aug 2012 14:47:08 +0200, Julien Nicoulaud notifications@github.com wrote:

This fix is not OK, this will trigger highlighting a lot more often and make the whole shell even more slower...

---

Reply to this email directly or view it on GitHub:
#90 (comment)

Tor Hedin Brønner

[danielshahaf]

#102 and #113 are duplicates of this issue.

[danielshahaf]

@hedning Why close? The issue still exists in latest master (hence I'm reopening).

[hedning]

Saw that it was duplicate, but I missed that the duplicates were closed.