Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Hopefully) Fix the tests on Python 3.4 on TravisCI. #55

Merged
merged 1 commit into from
Jan 27, 2018
Merged

(Hopefully) Fix the tests on Python 3.4 on TravisCI. #55

merged 1 commit into from
Jan 27, 2018

Conversation

icemac
Copy link
Member

@icemac icemac commented Jan 26, 2018 •
edited
Loading

Replaces #54.

@icemac icemac requested a review from tseaver January 26, 2018 09:50
This was referenced Jan 26, 2018
Closed
Merged
tseaver
tseaver approved these changes Jan 26, 2018
View reviewed changes
Copy link
Member

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems like a weird fix, but if it makes the tests pass for you, go for it. I have no clue why they pass for me without it.

@icemac icemac merged commit ccfec4d into master Jan 27, 2018
@icemac icemac deleted the fix-py34 branch January 27, 2018 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@icemac @tseaver