Fix deprecation warnings. #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the ones which have shown up when running the tests in the way the warning suggested it.
tseaver
reviewed
Jan 25, 2018
| @@ -111,7 +114,7 @@ def _doDelUsers(self, names): | |||
| def identify(self, auth): | |||
| if auth and auth.lower().startswith('basic '): | |||
| try: | |||
| name, password = decodestring(auth.split(' ')[-1].encode()).decode() \ | |||
| name, password = decodebytes(auth.split(' ')[-1].encode()).decode() \ | |||
There was a problem hiding this comment.
We just compared auth against native str above: are you confident it is really bytes?
There was a problem hiding this comment.
According to the documentation (https://docs.python.org/3/library/base64.html#base64.decodestring) base64.decodestring is a deprecated alias of decodebytes. I think at least my change does not make the code worse.
There was a problem hiding this comment.
OK, but if the Python3 stdlib is expecting bytes, we shouldn't be passing in auth as text, nor comparing / splitting it with str constants.
There was a problem hiding this comment.
I've opened #56 to track this issue.
|
Green Travis CI depends on merging #55 into this branch. |
tseaver
approved these changes
Jan 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the ones which have shown up when running the tests in the way the warning suggested it.