-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix queries and response packets content for undelegated tests #1150
Conversation
How can you change the query type when running a test case? |
You change query type directly in the code of the Test Case, for example here. And just add
|
@matsduf please re-review |
The "How to test" does not work. In undelegated test there is no DS query for DNSSEC11. The following command works better:
|
The result looks strange, but it probably does not affect the end result of Zonemaster. Issue #1169 has been created. |
Purpose
For undelegated tests (fake delegation), this PR adds the QR flag in queries and AA flag depending if DS record is provided or not.
Context
Fixes #1100
Changes
How to test this PR
zonemaster-cli 190.187.193.in-addr.arpa --ns ns1.oxilion.nl --ns ns2.oxilion.nl --ns ns3.oxilion.net --raw --level debug3 --test dnssec/dnssec11 > debug-dnssec11
Inspect debug file
debug-dnssec11
. Search fortype=DS
. Look at flags and packet content thereafter. You can change query type in dnssec11 and compare.