Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent logging #1169

Closed
matsduf opened this issue Dec 16, 2022 · 1 comment · Fixed by #1256
Closed

Inconsistent logging #1169

matsduf opened this issue Dec 16, 2022 · 1 comment · Fixed by #1256
Assignees
@tgreenx
Labels
S-PRforIssue Status: There is a PR that is meant to resolve the issue T-Bug Type: Bug in software or error in test case description
Milestone
v2023.2

Comments

@matsduf
Copy link
Contributor

matsduf commented Dec 16, 2022 •
edited by tgreenx
Loading

Two log files (output of zonemaster-cli) are created from undelegated tests of DNSSEC02 with and without, respectively, DS information. The NS and DS information is the same as the one found in the parent zone.

zonemaster-cli zonemaster.net --raw --ns nsu.dnsnode.net. --ns nsa.dnsnode.net. --ns nsp.dnsnode.net. --ns ns2.nic.fr --level debug3 --test dnssec/dnssec02 --ds 14967,13,2,F1129CEBE8060B98E352D8C1E5F783130705CAF1590C2275AF05FA9062CCD5F7 > debug-dnssec02-zonemaster.net--undelegated-with-ds

zonemaster-cli zonemaster.net --raw --ns nsu.dnsnode.net. --ns nsa.dnsnode.net. --ns nsp.dnsnode.net. --ns ns2.nic.fr --level debug3 --test dnssec/dnssec02 > debug-dnssec02-zonemaster.net--undelegated-without-ds

In debug-dnssec02-zonemaster.net--undelegated-with-ds the following lines are found (only the first two instances are shown here). Note that there is no information on the actual DS. A FAKED_RETURN is missing for each instance.

   0.47 DEBUG2    QUERY   flags={"dnssec":1}; ip=192.5.6.30; name=zonemaster.net; type=DS
   0.47 DEBUG     FAKE_DS_RETURNED   from=a.gtld-servers.net/192.5.6.30; name=zonemaster.net
   0.47 DEBUG2    QUERY   flags={"dnssec":1}; ip=2001:503:a83e::2:30; name=zonemaster.net; type=DS
   0.47 DEBUG     FAKE_DS_RETURNED   from=a.gtld-servers.net/2001:503:a83e::2:30; name=zonemaster.net

In debug-dnssec02-zonemaster.net--undelegated-without-ds the following lines are found (only the first two instances are shown here). Note that it is incorrectly called "FAKE_DELEGATION", but should be a FAKE_DS_RETURNED.

   0.49 DEBUG2    QUERY   flags={"dnssec":1}; ip=192.5.6.30; name=zonemaster.net; type=DS
   0.49 DEBUG2    FAKE_DELEGATION   class=IN; from=a.gtld-servers.net/192.5.6.30; name=zonemaster.net; type=DS
   0.49 DEBUG2    FAKED_RETURN   packet=;; ->>HEADER<<- opcode: QUERY, rcode: NOERROR, id: 0
   0.49 DEBUG2    FAKED_RETURN> ;; flags: qr aa ; QUERY: 1, ANSWER: 0, AUTHORITY: 0, ADDITIONAL: 0 
   0.49 DEBUG2    FAKED_RETURN> ;; QUESTION SECTION:
   0.49 DEBUG2    FAKED_RETURN> ;; zonemaster.net.      IN      DS
   0.49 DEBUG2    FAKED_RETURN> 
   0.49 DEBUG2    FAKED_RETURN> ;; ANSWER SECTION:
   0.49 DEBUG2    FAKED_RETURN> 
   0.49 DEBUG2    FAKED_RETURN> ;; AUTHORITY SECTION:
   0.49 DEBUG2    FAKED_RETURN> 
   0.49 DEBUG2    FAKED_RETURN> ;; ADDITIONAL SECTION:
   0.49 DEBUG2    FAKED_RETURN> 
   0.49 DEBUG2    FAKED_RETURN> ;; Query time: 0 msec
   0.49 DEBUG2    FAKED_RETURN> ;; EDNS: version 0; flags: do ; udp: 0
   0.49 DEBUG2    FAKED_RETURN> ;; SERVER: 192.5.6.30
   0.49 DEBUG2    FAKED_RETURN> ;; WHEN: Thu Jan  1 00:00:00 1970
   0.49 DEBUG2    FAKED_RETURN> ;; MSG SIZE  rcvd: 0
   0.49 DEBUG2    QUERY   flags={"dnssec":1}; ip=2001:503:a83e::2:30; name=zonemaster.net; type=DS
   0.49 DEBUG2    FAKE_DELEGATION   class=IN; from=a.gtld-servers.net/2001:503:a83e::2:30; name=zonemaster.net; type=DS
   0.49 DEBUG2    FAKED_RETURN   packet=;; ->>HEADER<<- opcode: QUERY, rcode: NOERROR, id: 0
   0.49 DEBUG2    FAKED_RETURN> ;; flags: qr aa ; QUERY: 1, ANSWER: 0, AUTHORITY: 0, ADDITIONAL: 0 
   0.49 DEBUG2    FAKED_RETURN> ;; QUESTION SECTION:
   0.49 DEBUG2    FAKED_RETURN> ;; zonemaster.net.      IN      DS
   0.49 DEBUG2    FAKED_RETURN> 
   0.49 DEBUG2    FAKED_RETURN> ;; ANSWER SECTION:
   0.49 DEBUG2    FAKED_RETURN> 
   0.49 DEBUG2    FAKED_RETURN> ;; AUTHORITY SECTION:
   0.49 DEBUG2    FAKED_RETURN> 
   0.49 DEBUG2    FAKED_RETURN> ;; ADDITIONAL SECTION:
   0.49 DEBUG2    FAKED_RETURN> 
   0.49 DEBUG2    FAKED_RETURN> ;; Query time: 0 msec
   0.49 DEBUG2    FAKED_RETURN> ;; EDNS: version 0; flags: do ; udp: 0
   0.49 DEBUG2    FAKED_RETURN> ;; SERVER: 2001:503:a83e::2:30
   0.49 DEBUG2    FAKED_RETURN> ;; WHEN: Thu Jan  1 00:00:00 1970
   0.49 DEBUG2    FAKED_RETURN> ;; MSG SIZE  rcvd: 0
@matsduf matsduf added this to the v2023.1 milestone Dec 16, 2022
@matsduf matsduf mentioned this issue Dec 16, 2022
Merged
@matsduf matsduf modified the milestones: v2023.1, v2023.2 Jun 26, 2023
tgreenx added a commit to tgreenx/zonemaster-engine that referenced this issue Jul 18, 2023
@tgreenx
Refactor of logging for undelegated tests
c50b3bb 
- Rename ADDED_FAKE_DELEGATION to FAKE_DELEGATION_ADDED for consistency
- Rename FAKE_DELEGATION to FAKE_DELEGATION_RETURNED for consistency
- Rename FAKE_DS to FAKE_DS_ADDED for consistency
- Add messages IDs for FAKE_DS_ADDED and FAKE_DS_RETURNED
- Make FAKE_DS_RETURNED arguments consistent with FAKE_DELEGATION_RETURNED
- Return a FAKED_RETURN message when a fake DS exists (- relates to issue zonemaster#1169)
@tgreenx tgreenx mentioned this issue Jul 18, 2023
Merged
@tgreenx tgreenx linked a pull request Jul 18, 2023 that will close this issue
Refactor of logging for undelegated tests #1256
Merged
@tgreenx tgreenx added T-Bug Type: Bug in software or error in test case description S-PRforIssue Status: There is a PR that is meant to resolve the issue labels Jul 18, 2023
tgreenx added a commit to tgreenx/zonemaster-engine that referenced this issue Jul 26, 2023
@tgreenx
Refactor of logging for undelegated tests
b9e77f1 
- Rename ADDED_FAKE_DELEGATION to FAKE_DELEGATION_ADDED for consistency
- Rename FAKE_DELEGATION to FAKE_DELEGATION_RETURNED for consistency
- Rename FAKE_DS to FAKE_DS_ADDED for consistency
- Add messages IDs for FAKE_DS_ADDED and FAKE_DS_RETURNED
- Make FAKE_DS_RETURNED arguments consistent with FAKE_DELEGATION_RETURNED
- Return a FAKED_RETURN message when a fake DS exists (- relates to issue zonemaster#1169)
@matsduf
Copy link
Contributor Author

matsduf commented Mar 19, 2024

Resolved by #1256

@matsduf matsduf closed this as completed Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tgreenx tgreenx

Labels
S-PRforIssue Status: There is a PR that is meant to resolve the issue T-Bug Type: Bug in software or error in test case description
Projects
None yet
Milestone
v2023.2
Development

Successfully merging a pull request may close this issue.

Refactor of logging for undelegated tests tgreenx/zonemaster-engine
2 participants
@matsduf @tgreenx