Miscellaneous fixes

core/src/main/kotlin/in/specmatic/core/Feature.kt

@@ -322,8 +322,20 @@ data class Feature(
     }
 
     fun generateContractTestScenarios(suggestions: List<Scenario>): Sequence<Scenario> {
-        return resolverStrategies.generation.let {
-            it.positiveTestScenarios(this, suggestions) + it.negativeTestScenarios(this)
+        return try {
+            resolverStrategies.generation.let {
+                it.positiveTestScenarios(this, suggestions) + it.negativeTestScenarios(this)
+            }
+        }
+        catch(e: Throwable) {
+            logger.log(e)
+            throw e
+        }
+    }
+
+    fun validateExampleRows() {
+        scenarios.forEach { scenario ->
+            scenario.validateExamples(resolverStrategies)
         }
     }
 

core/src/main/kotlin/in/specmatic/core/Scenario.kt

@@ -311,6 +311,16 @@ data class Scenario(
         }
     }
 
+    fun validateExamples(
+        resolverStrategies: ResolverStrategies,
+    ) {
+        val rowsToValidate = examples.flatMap { it.rows }
+
+        rowsToValidate.forEach { row ->
+            newBasedOn(row, resolverStrategies).first()
+        }
+    }
+
     fun generateTestScenarios(
         resolverStrategies: ResolverStrategies,
         variables: Map<String, String> = emptyMap(),

core/src/main/kotlin/in/specmatic/proxy/Proxy.kt

@@ -143,16 +143,12 @@ class Proxy(host: String, port: Int, baseURL: String, private val outputDirector
         val gherkin = toGherkinFeature("New feature", stubs)
         val base = "proxy_generated"
         val featureFileName = "$base.yaml"
-        val openApi = parseGherkinStringToFeature(gherkin).toOpenApi()
 
         if(stubs.isEmpty()) {
             println("No stubs were recorded. No contract will be written.")
         } else {
             outputDirectory.createDirectory()
 
-            println("Writing contract to $featureFileName")
-            outputDirectory.writeText(featureFileName, Yaml.pretty(openApi))
-
             val stubDataDirectory = outputDirectory.subDirectory("${base}_data")
             stubDataDirectory.createDirectory()
 
@@ -161,6 +157,12 @@ class Proxy(host: String, port: Int, baseURL: String, private val outputDirector
                 println("Writing stub data to $fileName")
                 stubDataDirectory.writeText(fileName, namedStub.stub.toJSON().toStringLiteral())
             }
+
+            val openApi = parseGherkinStringToFeature(gherkin).toOpenApi()
+
+            println("Writing specification to $featureFileName")
+            outputDirectory.writeText(featureFileName, Yaml.pretty(openApi))
+
         }
     }
 }

core/src/test/kotlin/in/specmatic/proxy/ProxyTest.kt

@@ -85,7 +85,7 @@ internal class ProxyTest {
             )
         }.doesNotThrowAnyException()
         assertThatCode { parsedJSON(fakeFileWriter.receivedStub ?: "") }.doesNotThrowAnyException()
-        assertThat(fakeFileWriter.receivedPaths.toList()).isEqualTo(listOf("proxy_generated.yaml", "stub0.json"))
+        assertThat(fakeFileWriter.receivedPaths.toList()).containsExactlyInAnyOrder("proxy_generated.yaml", "stub0.json")
     }
 
     @Test
@@ -108,7 +108,7 @@ internal class ProxyTest {
             )
         }.doesNotThrowAnyException()
         assertThatCode { parsedJSON(fakeFileWriter.receivedStub ?: "") }.doesNotThrowAnyException()
-        assertThat(fakeFileWriter.receivedPaths).isEqualTo(listOf("proxy_generated.yaml", "stub0.json"))
+        assertThat(fakeFileWriter.receivedPaths).containsExactlyInAnyOrder("proxy_generated.yaml", "stub0.json")
     }
 
     @Test

junit5-support/src/main/kotlin/in/specmatic/test/SpecmaticJUnitSupport.kt

@@ -173,7 +173,6 @@ open class SpecmaticJUnitSupport {
 
     private fun loadExceptionAsTestError(e: Throwable): Stream<DynamicTest> {
         return sequenceOf(DynamicTest.dynamicTest("Load Error") {
-            logger.log(e)
             ResultAssert.assertThat(Result.Failure(exceptionCauseMessage(e))).isSuccess()
         }).asStream()
     }
@@ -251,8 +250,6 @@ open class SpecmaticJUnitSupport {
             return loadExceptionAsTestError(e)
         }
 
-        var checkedAPIs = false
-
         val testBaseURL = try {
             constructTestBaseURL()
         } catch (e: Throwable) {
@@ -261,16 +258,30 @@ open class SpecmaticJUnitSupport {
             throw(e)
         }
 
+        return try {
+            dynamicTestStream(testScenarios, testBaseURL, timeout)
+        } catch(e: Throwable) {
+            logger.logError(e)
+            loadExceptionAsTestError(e)
+        }
+    }
+
+    private fun dynamicTestStream(
+        testScenarios: Sequence<ContractTest>,
+        testBaseURL: String,
+        timeout: Int
+    ): Stream<DynamicTest> {
+        var checkedAPIs = false
         return testScenarios.map { testScenario ->
             DynamicTest.dynamicTest(testScenario.testDescription()) {
                 threads.add(Thread.currentThread().name)
 
-                if(!checkedAPIs) {
+                if (!checkedAPIs) {
                     checkedAPIs = true
 
                     try {
                         queryActuator()
-                    } catch(exception: Throwable) {
+                    } catch (exception: Throwable) {
                         logger.log(exception, "Failed to query actuator with error")
                     }
                 }
@@ -297,11 +308,10 @@ open class SpecmaticJUnitSupport {
                         else -> ResultAssert.assertThat(result).isSuccess()
                     }
 
-                } catch(e: Throwable) {
+                } catch (e: Throwable) {
                     throw e
-                }
-                finally {
-                    if(testResult != null) {
+                } finally {
+                    if (testResult != null) {
                         val (result, response) = testResult
                         openApiCoverageReportInput.addTestReportRecords(testScenario.testResultRecord(result, response))
                     }
@@ -406,7 +416,7 @@ open class SpecmaticJUnitSupport {
                 securityConfiguration
             ).copy(testVariables = config.variables, testBaseURLs = config.baseURLs).loadExternalisedExamples()
 
-
+        feature.validateExampleRows()
 
         val suggestions = when {
             suggestionsPath.isNotEmpty() -> suggestionsFromFile(suggestionsPath)