Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(boards): Remove split right keyboard names #658

Merged
merged 3 commits into from
Sep 26, 2021

Conversation

Nicell
Copy link
Member

@Nicell Nicell commented Feb 1, 2021

This PR's purpose is to reduce people's chances of accidentally pairing with the wrong half of the board, as they shouldn't be pairing with the peripheral half.

@Nicell Nicell added shields PRs and issues related to shields refactor labels Feb 1, 2021
@Nicell Nicell requested a review from petejohanson February 1, 2021 20:43
@Nicell Nicell force-pushed the boards/remove-split-right-names branch from 2be2568 to 052211e Compare February 2, 2021 06:09
@Nicell Nicell force-pushed the boards/remove-split-right-names branch from 052211e to bf86f38 Compare March 27, 2021 19:06
@fsargent
Copy link
Contributor

fsargent commented May 3, 2021

What’s the purpose of this change?

@Nicell Nicell force-pushed the boards/remove-split-right-names branch from bf86f38 to 466d848 Compare July 24, 2021 18:34
Copy link
Contributor

@petejohanson petejohanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally had a chance to test this here, and works fine, and I fully agree this will help reduce support issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor shields PRs and issues related to shields
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants