-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
duckboard compatibility #634
Conversation
"merge main zmk updates"
…ate OLED and LED toggles
|
I've been consider whether to zap that completely. Can you give me a link to a failed build to show what happens w/ it in place? |
It's specifically the
Tried for duckboard, corne_left, and romac. When prj.conf is removed, the corne and romac build (the duckboard requires a nice_nano_v2.overlay file as well) (note: this is all using the docker container of the duckboard fork in VSCode) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few items, and then there are several build artifacts that snuck into this. Please remove those by doing an interactive rebase and editing the commits, so we avoid growing the git repo unnecessarily with those in the history.
Thanks!
@@ -0,0 +1,5 @@ | |||
/CMakeCache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't be necessary. Please remove the file.
@@ -0,0 +1,65 @@ | |||
# This is the CMakeCache file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accidental addition, it seems.
config ZMK_KEYBOARD_NAME | ||
default "duckboard" | ||
|
||
config ZMK_USB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These defaults should be coming from the controller selected, not from the shield.
@@ -0,0 +1,51 @@ | |||
# Copyright (c) 2020 The ZMK Contributors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep these files focused on settings specific to this shield, not general ZMK configuration items.
@@ -0,0 +1,3 @@ | |||
CONFIG_ZMK_RGB_UNDERGLOW=y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this file
* Author: Jack Hartstein | ||
*/ | ||
|
||
#include "duckboard.dtsi" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there's no left/right, etc nor need to re-use any common settings, please remove the duckboard.dtsi
file and incorporate those DT items into this main overlay file.
Thank you, contributor, for your patience with how long review and merge of boards/shields has taken! There are three recent refactors/changes to boards and shields that require some attention, and then we can finally get this PR merged!
Hardware MetadataThe ProblemWhen first developing the process around contributing new shields/boards to ZMK, we failed to recognize that several key files (setup scripts, documentation page of supported hardware, and GH Action The FixBy adding discrete metadata files that are located with the boards/shields in question, and using that metadata to generate setup scripts, website hardware list, etc., users can contributing new hardware descriptions without the need to change the same files that other contributors are changing. Next StepsFirst, refer to https://zmk.dev/docs/development/hardware-metadata-files to familiarize yourself with the new metadata file format. Next, you have two options for fixing up your PR:
Pro Micro shield DT naming changesIn #876, we have simplified the DT naming for the "nexus node" we expose for pro-micro compatible boards, deprecating the use of Please see https://zmk.dev/docs/development/new-shield#shield-overlays for the updated docs on this. Split Shield Advertising ChangesIn addition, if this is a split PR, please see #658 where we have changed our conventions to remove the the name from the right sides, to prevent users attempting to pair with them and causing split sync issues. This also includes removing the " Left" suffix from the naming on the left side. See the changes in that PR for examples of what to change with your split shield. Getting HelpIf you have any questions about any of these changes, please comment here and tag @zmkfirmware/boards-shields or ask in the |
Hello! We're closing this PR due to there being no activity since the metadata update to ZMK in September of last year. If you are still interested in updating this PR, please let us know, and we can reopen it and review your changes (hopefully a lot faster this time)! |
This is written and tested firmware for the doodboard duckboard with a nice!nano. I have verified the features on my duckboard, and gotten reports from other's using my firmware for their duckboards from the doodboard discord server.