Doc update #1853
Merged
Doc update #1853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -595,7 +690,7 @@ There are lots of new events you can see them here: | |||
| http://symfony.com/doc/current/book/internals.html#events | |||
| http://symfony.com/doc/current/components/http_kernel/introduction.html#component-http-kernel-event-table | |||
|
|
|||
| The following list of even names have been removed: | |||
| The following list of event names have been removed: | |||
There was a problem hiding this comment.
Maybe also add a note to the top that there are some events being removed.
There was a problem hiding this comment.
are there? if they have already been removed, please let me know which and I will document it.
if someone is planning to remove them, then they should document it when they actually refactor the code.
|
Thanks a lot for this PR 👍 |
|
ACK thank you |
|
@cmfcmf - I corrected the events in this PR at your suggestion. I believe this PR is ready for merge unless there is other objection |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doc re-organization highlighting emphasis on maintaining BC but clearly outlining areas where it is broken.
/cc @cmfcmf