Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FOSJsRoutingBundle #1765

Merged
merged 2 commits into from
Jun 30, 2014
Merged

Add FOSJsRoutingBundle #1765

merged 2 commits into from
Jun 30, 2014

Conversation

craigh
Copy link
Member

@craigh craigh commented Jun 14, 2014

refs #1552

ping @cmfcmf @Guite

I am pretty sure this is correct, but I have yet to figure out to make it work in my own javascript file. I know that it is trying to work, but failing.

for example

var route = Routing.generate('zikulaextensionlibrarymodule_ajax_setversionstatus', null, true);

returns: Error: The route "zikulaextensionlibrarymodule_ajax_setversionstatus" does not exist.

so, I need some ideas.

@cmfcmf
Copy link
Contributor

cmfcmf commented Jun 14, 2014

so, I need some ideas.

Please check if you see the route in the RoutesModule admin interface. If not, click reload routes and check again.

@@ -40,6 +40,7 @@
"drak/doctrine1": "dev-master",
"drak/smarty": "dev-master",
"elao/web-profiler-extra-bundle" : "dev-master",
"friendsofsymfony/jsrouting-bundle": "@stable",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want stable, use a version number/range.

@Guite Guite added this to the 1.4.0 milestone Jun 16, 2014
@craigh
Copy link
Member Author

craigh commented Jun 29, 2014

@cmfcmf - I think I will close this PR unless it can be of a help to you somehow. I thought it would be relatively little simple thing, but (as usual) I was wrong and in over my head. How would you like me to proceed?

@cmfcmf
Copy link
Contributor

cmfcmf commented Jun 30, 2014

@craigh Also notice the expose option as described here.

And actually, you do not event need to use the command line. Just make sure to expose some routes. To expose all routes for testing, add the following lines to config.yml:

fos_js_routing:
    routes_to_expose: [".*"]

@craigh
Copy link
Member Author

craigh commented Jun 30, 2014

I was preferring not to use the command line, but was trying to see if anything was working via that method.

let me rephrase my previous comment: I don't want to be working on this anymore 😉 would you please take it over ❓ what is the best way to hand off the work to you? just close the PR or something else?

@cmfcmf
Copy link
Contributor

cmfcmf commented Jun 30, 2014

@craigh Ok I understand. So.. Please remove your last commit and merge afterwards. It's working.

@craigh
Copy link
Member Author

craigh commented Jun 30, 2014

remove the commit ca47292 ?

@cmfcmf
Copy link
Contributor

cmfcmf commented Jun 30, 2014

remove the commit ca47292 ?

Yes. This is not needed (works without the locale parameter).

@craigh
Copy link
Member Author

craigh commented Jun 30, 2014

commit is removed. merge at your whim 🐐

@cmfcmf cmfcmf changed the title [WIP][RFC] add FOSJsRoutingBundle Add FOSJsRoutingBundle Jun 30, 2014
cmfcmf added a commit that referenced this pull request Jun 30, 2014
@cmfcmf cmfcmf merged commit 958c42a into zikula:1.4 Jun 30, 2014
@cmfcmf
Copy link
Contributor

cmfcmf commented Jun 30, 2014

Implementation example: zikula/ExtensionLibrary@a6226e6...7c16e80

@craigh craigh deleted the FOSjsRouting branch July 1, 2014 01:56
@craigh craigh mentioned this pull request Jul 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants