std.{coff,elf}: Remove the {MachineType,EM}.toTargetCpuArch() functions.
#21177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubkon
requested changes
Aug 23, 2024
alexrp
force-pushed
the
elf-coff-conv
branch
2 times, most recently
from
bca68db
to
a878785
Compare
These are fundamentally incapable of producing accurate information for reasons I've laid out in ziglang#20771. Since our only use of these functions is to check that object files have the correct machine type, and since ziglang#21020 made `std.Target.to{Coff,Elf}Machine()` more accurate, just switch these checks over to that and compare the machine type tags instead. Closes ziglang#20771.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are fundamentally incapable of producing accurate information for reasons I've laid out in #20771. Since our only use of these functions is to check that object files have the correct machine type, and since #21020 made
std.Target.to{Coff,Elf}Machine()more accurate, just switch these checks over to that and compare the machine type tags instead.Closes #20771.