Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std.Target: Assorted corrections, plus cleanup around ELF/COFF machine types #21020

Merged
merged 14 commits into from
Aug 16, 2024
Merged

std.Target: Assorted corrections, plus cleanup around ELF/COFF machine types #21020

merged 14 commits into from
Aug 16, 2024

Conversation

alexrp
Copy link
Contributor

@alexrp alexrp commented Aug 10, 2024

No description provided.

@alexrp alexrp force-pushed the target-fixes branch 5 times, most recently from baa28d6 to 80f771d Compare August 13, 2024 17:47
@alexrp alexrp mentioned this pull request Aug 13, 2024
Closed
@alexrp
Copy link
Contributor Author

alexrp commented Aug 14, 2024

Unrelated hang on aarch64-macos-debug.

@alexrp
std.Target: Make some functions handle driverkit alongside other Appl…
0def4e0 
…e OSs.

Reference for versions: https://developer.apple.com/support/xcode
@alexrp
std.Target: Fix isGnuLibC() to handle hurd too.
fc93ab7
@alexrp
std.Target: Change requiresLibC() to return true for aix.
1e67221 
AIX does not have a stable syscall interface; libc is required.
@alexrp
std.Target: Clean up Arch.toElfMachine().
9246c88
@alexrp
std.Target: Fix Arch.toElfMachine() for arc.
6c27cab 
The arc tag means ARCv2.
@alexrp
std.Target: Fix Arch.toElfMachine() for mips.
490b328 
EM_MIPS_RS3_LE is obsolete; all mips targets just use EM_MIPS.

Also, fun fact: EM_MIPS_RS3_LE is actually big endian!
@alexrp
std.Target: Clean up Arch.toCoffMachine().
8516a6a
@alexrp
std.Target: Don't match big endian architectures in Arch.toCoffMachin…
b24fc35 
…e().

All of these were mapping to types that are little endian. In fact, I can find
no evidence that either Windows or UEFI have ever been used on big endian
systems.
@alexrp
std.Target: Don't match PowerPC in Arch.toCoffMachine().
65affb1 
It's entirely unclear whether this should map to POWERPC or POWERPCFP, and as I
can find no evidence of people producing PE files for PowerPC since Windows NT,
let's just not make a likely-wrong guess. We can revisit this if the need ever
actually arises.
@alexrp
std.coff: Remove MachineType.fromTargetCpuArch().
ac9ca7d 
This does the same thing as std.Target.Cpu.Arch.toCoffMachine(). Just use that.
@alexrp
std.coff: Capitalize MachineType.{Unknown,Thumb} for consistency.
b01c595
@alexrp
std.Target: Pull toCoffMachine()/toElfMachine() up from Arch to Target.
5504386 
This enables them to give more correct results.

Contributes to ziglang#20771.
@alexrp
std.Target: Return the correct value for elfiamcu in toElfMachine().
9b5c992
@alexrp
std.Target: Return the correct value for 32-bit sparc v9 in toElfMach…
6db9ad7 
…ine().
@andrewrk andrewrk merged commit 05c7968 into ziglang:master Aug 16, 2024
10 checks passed
@andrewrk
Copy link
Member

Thanks!

@alexrp alexrp deleted the target-fixes branch August 16, 2024 05:42
alexrp added a commit to alexrp/zig that referenced this pull request Aug 19, 2024
@alexrp
std.{coff,elf}: Remove the {MachineType,EM}.toTargetCpuArch() functions.
7b5c24e 
These are fundamentally incapable of producing accurate information for reasons
I've laid out in ziglang#20771. Since our only use of these functions is to check that
object files have the correct machine type, and since ziglang#21020 made
`std.Target.to{Coff,Elf}Machine()` more accurate, just switch these checks over
to that and compare the machine type tags instead.

Closes ziglang#20771.
@alexrp alexrp mentioned this pull request Aug 23, 2024
Merged
alexrp added a commit to alexrp/zig that referenced this pull request Aug 23, 2024
@alexrp
std.{coff,elf}: Remove the {MachineType,EM}.toTargetCpuArch() functions.
6467f3d 
These are fundamentally incapable of producing accurate information for reasons
I've laid out in ziglang#20771. Since our only use of these functions is to check that
object files have the correct machine type, and since ziglang#21020 made
`std.Target.to{Coff,Elf}Machine()` more accurate, just switch these checks over
to that and compare the machine type tags instead.

Closes ziglang#20771.
alexrp added a commit to alexrp/zig that referenced this pull request Aug 23, 2024
@alexrp
std.{coff,elf}: Remove the {MachineType,EM}.toTargetCpuArch() functions.
5d6f274 
These are fundamentally incapable of producing accurate information for reasons
I've laid out in ziglang#20771. Since our only use of these functions is to check that
object files have the correct machine type, and since ziglang#21020 made
`std.Target.to{Coff,Elf}Machine()` more accurate, just switch these checks over
to that and compare the machine type tags instead.

Closes ziglang#20771.
alexrp added a commit to alexrp/zig that referenced this pull request Aug 23, 2024
@alexrp
std.{coff,elf}: Remove the {MachineType,EM}.toTargetCpuArch() functions.
a69f55a 
These are fundamentally incapable of producing accurate information for reasons
I've laid out in ziglang#20771. Since our only use of these functions is to check that
object files have the correct machine type, and since ziglang#21020 made
`std.Target.to{Coff,Elf}Machine()` more accurate, just switch these checks over
to that and compare the machine type tags instead.

Closes ziglang#20771.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexrp @andrewrk