build: fix module path resolution #15717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radarroark
changed the title
This was referenced May 16, 2023
malcolmstill
added a commit
to malcolmstill/zware
that referenced
this pull request
Jul 8, 2023
Not ready to merge. After these changes, the modules can individually build with 0.11.0-dev.3132+465272921 but the testrunner build command fails: ``` $ zig build --build-file test/testrunner/build.zig --prefix ./ zig build-exe testrunner Debug native: error: warning: FileNotFound: test/testrunner/src/main.zig error: FileNotFound ``` Yours truly looked into it and found that it is a build system bug. Here's the fix: ziglang/zig#15717 Hopefully that can get into the release. Shake and bake! --------- Co-authored-by: Malcolm Still <malcolm.still@gmail.com>
|
Thanks! I should have merged this ages ago. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15767.
FileSource.getPathalready callspathFromRoot, soappendModuleArgsdoes not need to. Running it twice breaks the path resolution when the module'ssource_fileis a relative path such as../../src/main.zig.