-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes for compatibility with zig 0.11.0 #190
Conversation
Legend! Amazing @radarroark, thanks! With ziglang/zig#15602 having dropped and ziglang/zig#15705 dropping soon, there might also be some changes to make to the testrunner for parsing the |
We'll also need to fix any casts ziglang/zig#16163 |
All casts should be fixed now. The powers that be think they can stop radar with all these breaking changes, but they only make me stronger... Ah, but there's one more error in the testrunner. Looks like some kind of workaround but wasn't sure what to do with it:
|
It might be with recent changes that those particular However, I'm expecting because of ziglang/zig#15602 and ziglang/zig#15705 that the json parsing stuff will be totally broken anyway. |
@radarroark just fixed some conflicts on your branch for this change #192. I'm going to see if I can work around the testrunner not building and take a look at it what changes are required for the JSON parser stuff due to ziglang/zig#15602 and ziglang/zig#15705 |
Ah so we can still build |
ziglang/zig#15981 may be what we need; trying it out now. |
Green light means go @radarroark! |
# Description Follow up to #190 to fix the `examples/fib` example + update code in README
Thanks for all the help on this @radarroark |
You are welcome sir |
Not ready to merge. After these changes, the modules can individually build with 0.11.0-dev.3132+465272921 but the testrunner build command fails:
Yours truly looked into it and found that it is a build system bug. Here's the fix: ziglang/zig#15717 Hopefully that can get into the release. Shake and bake!