Issue/1298 eslint rule no useless fragments #1673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
issue/1298-eslint-rule-no-useless-fragments
branch
from
275b564 to
17d9f42
Compare
ghost
force-pushed
the
issue/1298-eslint-rule-no-useless-fragments
branch
from
17d9f42 to
7d3b29b
Compare
nehahirve92
requested review from
ziggabyte,
richardolsson,
annikalindberg and
alexandrakoch
|
Maybe you can have a look at reviewing this @ziggabyte? |
…98-eslint-rule-no-useless-fragments
ziggabyte
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the eslint rule Disallow unnecessary fragments (
react/jsx-no-useless-fragment)And refactors any instances where this is the case.
I chose to render
nullin a lot of cases where we were rendering empty fragments; see philosophy here https://kentcdodds.com/blog/use-ternaries-rather-than-and-and-in-jsxIn cases where Fragments were essentially serving to change type from a ReactNode to a JSX.Element (strings or numbers), I wrapped these in tags instead.
tests/organize/tags/add.spec.tsseems flaky. It's failing locally but was also failing locally on a cleanmainCloses #1298
Screenshots
[Add screenshots here]
Changes
[Add a list of features added/changed, bugs fixed etc]
Notes to reviewer
[Add instructions for testing]
Related issues
Resolves #[id]