Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add eslint rule react/jsx-no-useless-fragment #1298

Closed
2 tasks
richardolsson opened this issue May 5, 2023 · 1 comment · Fixed by #1673
Closed
2 tasks

Add eslint rule react/jsx-no-useless-fragment #1298

richardolsson opened this issue May 5, 2023 · 1 comment · Fixed by #1673
Assignees
@nehahirve92
Labels
🧑‍💻 dx Developer Experience 🚪 entry-level Good for newcomers 🐬 Medium Just a nice sized issue. 🏗 refactor

Comments

@richardolsson
Copy link
Member

Description

Developers should be alerted when adding unnecessary fragments.

Relevant Job Stories

None

Prerequisites

None

Requirements

  • Add the react/jsx-no-useless-fragment eslint rule
  • Fix all errors that arise when the rule is added.

Possible implementations

None

Design specifications

None

Open questions

If the amount of errors seem overwhelming, raise the issue to be discussed with the core team.
@richardolsson richardolsson added 🚪 entry-level Good for newcomers 🧑‍💻 dx Developer Experience 🏗 refactor labels May 5, 2023
@richardolsson richardolsson added the 🐬 Medium Just a nice sized issue. label Jun 2, 2023
@richardolsson richardolsson mentioned this issue Dec 3, 2023
Closed
2 tasks
@nehahirve92
Copy link
Collaborator

@richardolsson Great; I'll work on this first (don't have permission to assign myself)

@nehahirve92 nehahirve92 mentioned this issue Dec 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nehahirve92 nehahirve92

Labels
🧑‍💻 dx Developer Experience 🚪 entry-level Good for newcomers 🐬 Medium Just a nice sized issue. 🏗 refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue/1298 eslint rule no useless fragments zetkin/app.zetkin.org
2 participants
@richardolsson @nehahirve92