Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta Release #2933

Closed
wants to merge 29 commits into from
Closed

Beta Release #2933

wants to merge 29 commits into from

Conversation

github-actions[bot]
Copy link
Contributor

Created by Github action

github-actions bot and others added 15 commits July 24, 2024 13:35
Created by Github action

---------

Co-authored-by: Andres Galindo <agalin920@gmail.com>
Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Created by Github action

---------

Co-authored-by: Andres Galindo <agalin920@gmail.com>
Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Andres Galindo <agalin920@gmail.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Created by Github action

---------

Co-authored-by: Andres Galindo <agalin920@gmail.com>
Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Co-authored-by: Andres Galindo <agalin920@gmail.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Created by Github action

---------

Co-authored-by: Andres Galindo <agalin920@gmail.com>
Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Co-authored-by: Andres Galindo <agalin920@gmail.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Created by Github action

---------

Co-authored-by: Andres Galindo <agalin920@gmail.com>
Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Co-authored-by: Andres Galindo <agalin920@gmail.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Created by Github action

---------

Co-authored-by: Andres Galindo <agalin920@gmail.com>
Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Co-authored-by: Andres Galindo <agalin920@gmail.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Created by Github action

---------

Co-authored-by: Andres Galindo <agalin920@gmail.com>
Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
@zcolah
Copy link

zcolah commented Aug 30, 2024

SEO Tab

@finnar-bin

Bugs

High Priority

Medium Priority

Low Priority

Enhancements

  • Add See More Button to the Content and Meta Matched Words Section
    image

@finnar-bin
Copy link
Contributor

finnar-bin commented Aug 30, 2024

@zcolah

User can Navigate to the SEO Tab even if the changes in the Edit Tab cannot be saved due to an error. A user should not be able to navigate out to another tab or page if an error in saving occurs. Instead they should remain on the same page (URL) and read why the error happened. See Loom:https://www.loom.com/share/ccb4912b1637479aaaca3c17eba16d62

The save button got triggered due to the wysiwyg, the saved data was auto-formatted by the wysiwyg component on load. That most likely happened due to the old data being saved using the old wysiwyg and when it was loaded to the current wysiwyg it auto-formatted the text causing an on change which marked the content item as "dirty" because of the said change. If you just click save when this happens, it should no longer happen again since it essentially fixed the formatting already.

But regarding the issue where it still moved you to the SEO tab even if there was an error saving the file, I'll fix that.


Meta Image Does Not Appear in Social Media Previews https://www.loom.com/share/e2af6f73f2be443cb8cd840f7dc6c44f

I am using the media resolver to render the images in the social media previews, I reached out to @mattezra and he told me there are some ongoing issues with the media resolver api at the moment. It seems to be able to resolve some image zuids while for some other image zuids it fails to do so causing that issue.


Canonical Tag & Sitemap Priority Dropdown Menus cover/overlap with the Input itself. This makes it difficult to see the currently selected value. https://www.loom.com/share/af778d8ce6b14503beafa42d76b3c683

This is the default behavior of MUI's select component and it doesn't seem like there's a way to change the dropdown behavior to be like the autocomplete since it's using different popup components under the hood. There's already an open issue regarding this in the mui repo already but it doesn't seem like there's any working workaround to fix to it yet.


Meta Description Input Bug with Spaces at the end Please check if this is happening for Meta Title as well.
https://www.loom.com/share/8e137c06821d427a80c7baa1f025ef8c

This is only happens to multiline textfields (textarea) and is the default behavior as well. If you check out the input box in github below, it behaves the same way when you spam space towards the edge of the textarea. There's a workaround I found in this MUI issue but it makes it so that the text doesn't wrap around properly, you instead get a long horizontal scroll unless you deliberately press enter to go to a newline.

@giseleblair
Copy link
Contributor

@finnar-bin
Copy link
Contributor

@zcolah Here is my initial SEO Feedback https://www.loom.com/share/89504abcaf8d40f989d106ee0b81ee45?sid=f5fa66e7-7aae-44bc-85e7-de15184248b7

@zcolah regarding the twitter-related stuff
@giseleblair regarding the image disappearing when you clicked the customize image, the logic behind that is once that button is clicked, it then creates the og_image field which is then what's being checked for the meta image previews. The ask there was to always use the og_image field if it exists regardless if it's storing a file or not. @zcolah might need to also check into that flow.

@giseleblair
Copy link
Contributor

@finnar-bin @zcolah
Does this logic also apply to og_title/description and tc_image/title/description?
Once the user clicks on Customize Image does this add the og_image to the content model? Does this mean that the og_image content field for each item in the model gets populated? Or does this field remain blank? If this field remains blank, will Webengine revert back to prioritizing the first media field of the model? Does this also create a new version for all items in the model? Will it publish those changes? If so, how will the system decide which version to publish?

@finnar-bin
Copy link
Contributor

finnar-bin commented Sep 3, 2024

@giseleblair I cannot comment on how webengine will handle it but I believe there's going to be a change made to it as well that will follow the same logic for these changes in manager-ui to make sense, perhaps @jjaguilar08 could comment on this.

But regarding the og_image content field, when they click "Customize Image" it will essentially create a new empty og_image field in the content itself, all the content items will have this field but will be empty until the user explicitly adds a value into that field per content item.

finnar-bin and others added 2 commits September 4, 2024 10:43
Co-authored-by: Andres Galindo <agalin920@gmail.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Co-authored-by: Allen Pigar <50983144+allenpigar@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Created by Github action

---------

Co-authored-by: Andres Galindo <agalin920@gmail.com>
Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Co-authored-by: Allen Pigar <50983144+allenpigar@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@finnar-bin
Copy link
Contributor

Found a major bug that prevents creation of new dataset items. Fix created: #2945

@zcolah
Copy link

zcolah commented Sep 4, 2024

@finnar-bin here is my response

SEO Tab

Issue 1

Zosh: User can Navigate to the SEO Tab even if the changes in the Edit Tab cannot be saved due to an error. A user should not be able to navigate out to another tab or page if an error in saving occurs. Instead they should remain on the same page (URL) and read why the error happened. See Loom:https://www.loom.com/share/ccb4912b1637479aaaca3c17eba16d62

Nar: The save button got triggered due to the wysiwyg, the saved data was auto-formatted by the wysiwyg component on load. That most likely happened due to the old data being saved using the old wysiwyg and when it was loaded to the current wysiwyg it auto-formatted the text causing an on change which marked the content item as "dirty" because of the said change. If you just click save when this happens, it should no longer happen again since it essentially fixed the formatting already. But regarding the issue where it still moved you to the SEO tab even if there was an error saving the file, I'll fix that.

Thank you for clarifying and fixing this.

Issue 2

Zosh: Meta Image Does Not Appear in Social Media Previews https://www.loom.com/share/e2af6f73f2be443cb8cd840f7dc6c44f

Nar: I am using the media resolver to render the images in the social media previews, I reached out to @mattezra and he told me there are some ongoing issues with the media resolver api at the moment. It seems to be able to resolve some image zuids while for some other image zuids it fails to do so causing that issue.

Is this an issue only happening in stage or is it also happening in production? Do we have a timeline of when this will be fixed by @mattezra?

Issue 3

Zosh: Canonical Tag & Sitemap Priority Dropdown Menus cover/overlap with the Input itself. This makes it difficult to see the currently selected value. https://www.loom.com/share/af778d8ce6b14503beafa42d76b3c683
Nar: This is the default behavior of MUI's select component and it doesn't seem like there's a way to change the dropdown behavior to be like the autocomplete since it's using different popup components under the hood. There's already an open issue regarding this in the mui/material-ui#36776 already but it doesn't seem like there's any working workaround to fix to it yet.

Thank you for this added context. I read the thread and I understand why it appears the way it does in some contexts. For now let us pause the issue and not worry about it.

In the future we can explore potentially using the autocomplete input as the default input option for all drop downs in Edit Content Item and potentially the SEO tab as well. I have made a ticket for the same: #2947

Issue 4

Zosh: Meta Description Input Bug with Spaces at the end Please check if this is happening for Meta Title as well.
https://www.loom.com/share/8e137c06821d427a80c7baa1f025ef8c

Nar: This is only happens to multiline textfields (textarea) and is the default behavior as well. If you check out the input box in github below, it behaves the same way when you spam space towards the edge of the textarea. There's a workaround I found in mui/material-ui#41490 but it makes it so that the text doesn't wrap around properly, you instead get a long horizontal scroll unless you deliberately press enter to go to a newline.

Okay understood, we do not need to fix this for the time being then.

@zcolah
Copy link

zcolah commented Sep 4, 2024

1. Why does the image disappear after you click customize image?

Nar: The logic behind that is once that button is clicked, it then creates the og_image field which is then what's being checked for the meta image previews. The ask there was to always use the og_image field if it exists regardless if it's storing a file or not. @zcolah might need to also check into that flow.

@finnar-bin thank you for providing the above to context to @giseleblair on why there was no image.

@giseleblair here is a detailed breakdown of the rules of when which button appears and why. This will give you added context overall into how the buttons appear and why.

CleanShot 2024-09-04 at 23 24 32

2. Does this logic also apply to og_title/description and tc_image/title/description?

Currently it does not apply to og_title and og_description. I was not aware that users usually create a separate og_title and og_description field and that they use those for the SEO previews. I will need to ask Randy about how to handle these scenarios. Same goes for tc_image/title/description.

We were not aware that users create separate fields for twitter. We have not designed to accommodate for any of these scenarios. I will design a solution with Randy and get back to you.

3. Once the user clicks on Customize Image does this add the og_image to the content model?
Yes, once a user clicks on Customize Image, it adds an og_image field to the content model. Here are the details for the og_image field that will be created:

  • Field Label: Meta Image
  • API ID: og_image
  • Field Type: Media Field
  • Field Description: This field allows you to set an open graph image via the SEO tab. An Open Graph (OG) image is an image that appears on a social media post when a web page is shared.

4. Does this mean that the og_image content field for each item in the model gets populated? Or does this field remain blank? If this field remains blank, will Webengine revert back to prioritizing the first media field of the model?

This field will remain blank until a user uploads an image to the og_image field. With respect to your question on Web Engine, it will behave exactly how it currently does when a user has an empty og_image field.

  1. Does this also create a new version for all items in the model? Will it publish those changes? If so, how will the system decide which version to publish?

It does not create a new version for all items in the model. It will not publish those changes.

@giseleblair
Copy link
Contributor

@zcolah It seems like we are recreating the wheel here. Webengine already has all of this logic put in place. Overall, what needs to be displayed in this preview component is the real data that is generated by Webengine and not this simulated output. There are already inconsistencies on how Webengine and this preview component work. It also means that any updates done on Webengine regarding SEO will then need to be applied here, creating 2 touch points as opposed to 1. This will inevitably result in deviations between the Manager UI and Webengine.
For point 4 provide the exact behaviors that will result in creating an empty og_image field with regards to Webengine. This needs to be fully understood before we deploy as it could result in empty SEO tags for our customers.
For point 5, you mentioned the content will not be published. This makes it unclear as to how the content added to the og_image field is supposed to be pushed to production.

@ardeay
Copy link
Contributor

ardeay commented Sep 4, 2024

Webengine do not need to change for this update.

@giseleblair for 4 og_image will only be created as a field if the user engages with og image in the new SEO tab to add an image. Otherwise, default behavior. State this in a tooltip @zcolah

2. Does this logic also apply to og_title/description No, description and title are used for both SEO/OG. State this in a tooltip @zcolah

@giseleblair
Copy link
Contributor

I understand no updates need to be made to Webengine.
@ardeay regarding point 4: this still does not answer whether og_image will be populated for all items in a content model since the workflow is that og_image will be added to the model if the user interacts with Meta Image in the SEO tab. And if the answer is that it will not be populated, how does Webengine handle empty og_image fields?

@finnar-bin
Copy link
Contributor

finnar-bin commented Sep 5, 2024

So if I understood correctly, no webengine changes need to be made therefore that would mean we need to update the logic that's currently in place in manager-ui to match how webengine picks out an image to use as the seo meta image. I could reach out to @jjaguilar08 to get a full understanding regarding that.

And if the answer is that it will not be populated, how does Webengine handle empty og_image fields?

We could probably determine this once we know how webengine picks out an image to use as a meta image, for example if it always picks out the first image we could maybe put the og_image field as the first content field item perhaps? That way webengine would always pick the value in og_image if it contains an image else check the next available image in the other content item fields.

For now, I'll temporary pause making any more changes related to this (aside from bugs and vqa-related stuff) while waiting for a clear direction on how we'll go through with the meta image preview in manager-ui. @zcolah

finnar-bin and others added 2 commits September 12, 2024 08:54
Co-authored-by: Andres Galindo <agalin920@gmail.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Co-authored-by: Allen Pigar <50983144+allenpigar@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Created by Github action

---------

Co-authored-by: Andres Galindo <agalin920@gmail.com>
Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Co-authored-by: Allen Pigar <50983144+allenpigar@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@zcolah
Copy link

zcolah commented Sep 12, 2024

@finnar-bin

SEO Tab

Bugs

  • 1. Content and Meta Matched Words should not display special characters or spaces in the list of words. It should ignore them. See screenshot.

CleanShot 2024-09-13 at 01 09 53

  • 2. Words that appear less than 2 times are appearing in the Most Mentioned Words in Content Item. This should not happen.
    CleanShot 2024-09-13 at 01 09 19

@zcolah
Copy link

zcolah commented Sep 17, 2024

@finnar-bin

Bugs

Figma VQA

Primarily only tiny fixes needed with one material theme change.

Enhancements

  • Add Empty State Text for Content & Meta Matched Words Section: "No Matching Words"
  • Add Empty State Text for Most Mentioned Words in Content Item Section: "No words in your content item occur 2 or more times"

UI Updates

image

@zcolah
Copy link

zcolah commented Sep 19, 2024

Web Engine Changes Required

@jjaguilar08

We need the following changes made to Web Engine for the Twitter Card and Facebook Card previews

@giseleblair can assist with questions regarding these changes.

@finnar-bin
Copy link
Contributor

@shrunyan this material repo PR is also a dependency for the SEO tab changes
zesty-io/material#107

finnar-bin added a commit that referenced this pull request Sep 20, 2024
finnar-bin and others added 2 commits September 20, 2024 15:53
Co-authored-by: Andres Galindo <agalin920@gmail.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Co-authored-by: Allen Pigar <50983144+allenpigar@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Created by Github action

---------

Co-authored-by: Andres Galindo <agalin920@gmail.com>
Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Co-authored-by: Allen Pigar <50983144+allenpigar@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@zcolah
Copy link

zcolah commented Sep 23, 2024

@finnar-bin

Enhancement

  • SEO Tab & Create Page: Update the Column Widths to the following:

Left Column:

  • min-width: 640 px;
  • width: 60%;

Right Column:

  • width: fill up the remaining space
  • max width: 620 px

Bug

  • Remove the * from OG Title and TC Title unless the user has marked them as required fields in Schema. If the TC Title, TC Description, OG Title, or OG Description fields are marked as required then please ensure the content item cannot be saved until they have a value.

CleanShot 2024-09-23 at 08 39 17

@zcolah
Copy link

zcolah commented Sep 23, 2024

@finnar-bin

Bug (Blocking Release)

Bugs (Not blocking the release)

Error Blurb

CleanShot 2024-09-24 at 00 16 20

Meta Description Field

  • Multi part problem for Meta Description Field | Watch Loom: https://www.loom.com/share/e31401797acb44868a321537fb3b6ffd

    • Fix: Remove the notification alert for "Found Microsoft Smart single quotes and apostrophe. These special characters are not allowed in meta descriptions". This should only appear below the input and in the error blurb on Save.
    • Bug: Make Error Blurb render the following error in the Create App experience and SEO tab "Found Microsoft Smart single quotes and apostrophe. These special characters are not allowed in meta descriptions".
    • Enhancement: Update the Error Text for the Meta Description Field to say the following:

      Found Microsoft Smart single quotes and/or apostrophe. These special characters are not allowed in meta descriptions as it may lead to incorrect rendering, where characters show up as � or other odd symbols. Please use straight quotes (' and ") instead.

    • Enhancement: When copying the text from a Multi Line Text Field to the Meta Description field, replace “ and ” with "" in the copied text.

Text to use to test if bug is fixed:

An exploration of the historical significance, architectural grandeur, and evolving symbolism of Mumbai’s iconic Gateway of India from a historian's viewpoint.

Preview Cards

finnar-bin added a commit that referenced this pull request Sep 24, 2024
finnar-bin and others added 4 commits September 25, 2024 06:07
Co-authored-by: Andres Galindo <agalin920@gmail.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Co-authored-by: Allen Pigar <50983144+allenpigar@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Andres Galindo <agalin920@gmail.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Co-authored-by: Allen Pigar <50983144+allenpigar@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Andres Galindo <agalin920@gmail.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Co-authored-by: Allen Pigar <50983144+allenpigar@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@zcolah zcolah assigned shrunyan and unassigned shrunyan Sep 25, 2024
@zcolah zcolah added the vqa VQA is complete and approved label Sep 25, 2024
@zcolah
Copy link

zcolah commented Sep 25, 2024

@shrunyan @finnar-bin

This PR is now VQA Approved. Overall great work putting this all together @finnar-bin

Note:

  • I was unable to test the DUO Mode as I am unable to create a new instance in Stage. Seems like the only way to test the project would be in production.

  • There is still a Web Engine fix that is to be made. @shrunyan I will leave it to your discretion to wait for that fix to be made before deployment or after. In my eyes it is not critical to the project.

@zcolah
Copy link

zcolah commented Sep 25, 2024

Post Release Changes

@finnar-bin

May you please make two post release changes:

@finnar-bin
Copy link
Contributor

@zcolah I suggest creating a ticket for the post-release changes. This PR will be closed once it gets merged, that way it's easier to track those issues.

@zcolah
Copy link

zcolah commented Sep 26, 2024

@zcolah I suggest creating a ticket for the post-release changes. This PR will be closed once it gets merged, that way it's easier to track those issues.

#2974

finnar-bin and others added 2 commits September 27, 2024 06:28
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Andres Galindo <agalin920@gmail.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Created by Github action

---------

Co-authored-by: Andres Galindo <agalin920@gmail.com>
Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com>
Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Co-authored-by: Allen Pigar <50983144+allenpigar@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@shrunyan shrunyan deleted the branch beta September 26, 2024 23:14
@shrunyan shrunyan closed this Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vqa VQA is complete and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants