-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Beta Release #2933
Beta Release #2933
Conversation
Created by Github action --------- Co-authored-by: Andres Galindo <agalin920@gmail.com> Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com> Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com> Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com> Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com> Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Created by Github action --------- Co-authored-by: Andres Galindo <agalin920@gmail.com> Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com> Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Andres Galindo <agalin920@gmail.com> Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Created by Github action --------- Co-authored-by: Andres Galindo <agalin920@gmail.com> Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com> Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Co-authored-by: Andres Galindo <agalin920@gmail.com> Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Created by Github action --------- Co-authored-by: Andres Galindo <agalin920@gmail.com> Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com> Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Co-authored-by: Andres Galindo <agalin920@gmail.com> Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Created by Github action --------- Co-authored-by: Andres Galindo <agalin920@gmail.com> Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com> Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Co-authored-by: Andres Galindo <agalin920@gmail.com> Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Created by Github action --------- Co-authored-by: Andres Galindo <agalin920@gmail.com> Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com> Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Co-authored-by: Andres Galindo <agalin920@gmail.com> Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Created by Github action --------- Co-authored-by: Andres Galindo <agalin920@gmail.com> Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com> Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
SEO TabBugsHigh Priority
Medium Priority
Low Priority
Enhancements |
The save button got triggered due to the wysiwyg, the saved data was auto-formatted by the wysiwyg component on load. That most likely happened due to the old data being saved using the old wysiwyg and when it was loaded to the current wysiwyg it auto-formatted the text causing an on change which marked the content item as "dirty" because of the said change. If you just click save when this happens, it should no longer happen again since it essentially fixed the formatting already. But regarding the issue where it still moved you to the SEO tab even if there was an error saving the file, I'll fix that.
I am using the media resolver to render the images in the social media previews, I reached out to @mattezra and he told me there are some ongoing issues with the media resolver api at the moment. It seems to be able to resolve some image zuids while for some other image zuids it fails to do so causing that issue.
This is the default behavior of MUI's select component and it doesn't seem like there's a way to change the dropdown behavior to be like the autocomplete since it's using different popup components under the hood. There's already an open issue regarding this in the mui repo already but it doesn't seem like there's any working workaround to fix to it yet.
This is only happens to multiline textfields (textarea) and is the default behavior as well. If you check out the input box in github below, it behaves the same way when you spam space towards the edge of the textarea. There's a workaround I found in this MUI issue but it makes it so that the text doesn't wrap around properly, you instead get a long horizontal scroll unless you deliberately press enter to go to a newline. |
@zcolah Here is my initial SEO Feedback |
@zcolah regarding the twitter-related stuff |
@finnar-bin @zcolah |
@giseleblair I cannot comment on how webengine will handle it but I believe there's going to be a change made to it as well that will follow the same logic for these changes in manager-ui to make sense, perhaps @jjaguilar08 could comment on this. But regarding the |
Co-authored-by: Andres Galindo <agalin920@gmail.com> Co-authored-by: Stuart Runyan <shrunyan@gmail.com> Co-authored-by: Allen Pigar <50983144+allenpigar@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Created by Github action --------- Co-authored-by: Andres Galindo <agalin920@gmail.com> Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com> Co-authored-by: Stuart Runyan <shrunyan@gmail.com> Co-authored-by: Allen Pigar <50983144+allenpigar@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Found a major bug that prevents creation of new dataset items. Fix created: #2945 |
@finnar-bin here is my response SEO TabIssue 1
Thank you for clarifying and fixing this. Issue 2
Is this an issue only happening in stage or is it also happening in production? Do we have a timeline of when this will be fixed by @mattezra? Issue 3
Thank you for this added context. I read the thread and I understand why it appears the way it does in some contexts. For now let us pause the issue and not worry about it. In the future we can explore potentially using the autocomplete input as the default input option for all drop downs in Edit Content Item and potentially the SEO tab as well. I have made a ticket for the same: #2947 Issue 4
Okay understood, we do not need to fix this for the time being then. |
1. Why does the image disappear after you click customize image?
@finnar-bin thank you for providing the above to context to @giseleblair on why there was no image. @giseleblair here is a detailed breakdown of the rules of when which button appears and why. This will give you added context overall into how the buttons appear and why. 2. Does this logic also apply to og_title/description and tc_image/title/description? Currently it does not apply to og_title and og_description. I was not aware that users usually create a separate og_title and og_description field and that they use those for the SEO previews. I will need to ask Randy about how to handle these scenarios. Same goes for tc_image/title/description. We were not aware that users create separate fields for twitter. We have not designed to accommodate for any of these scenarios. I will design a solution with Randy and get back to you. 3. Once the user clicks on Customize Image does this add the og_image to the content model?
4. Does this mean that the og_image content field for each item in the model gets populated? Or does this field remain blank? If this field remains blank, will Webengine revert back to prioritizing the first media field of the model? This field will remain blank until a user uploads an image to the og_image field. With respect to your question on Web Engine, it will behave exactly how it currently does when a user has an empty og_image field.
It does not create a new version for all items in the model. It will not publish those changes. |
@zcolah It seems like we are recreating the wheel here. Webengine already has all of this logic put in place. Overall, what needs to be displayed in this preview component is the real data that is generated by Webengine and not this simulated output. There are already inconsistencies on how Webengine and this preview component work. It also means that any updates done on Webengine regarding SEO will then need to be applied here, creating 2 touch points as opposed to 1. This will inevitably result in deviations between the Manager UI and Webengine. |
Webengine do not need to change for this update. @giseleblair for
|
I understand no updates need to be made to Webengine. |
So if I understood correctly, no webengine changes need to be made therefore that would mean we need to update the logic that's currently in place in manager-ui to match how webengine picks out an image to use as the seo meta image. I could reach out to @jjaguilar08 to get a full understanding regarding that.
We could probably determine this once we know how webengine picks out an image to use as a meta image, for example if it always picks out the first image we could maybe put the For now, I'll temporary pause making any more changes related to this (aside from bugs and vqa-related stuff) while waiting for a clear direction on how we'll go through with the meta image preview in manager-ui. @zcolah |
) Resolves comments on #2933 (comment) [Screencast from 09-11-2024 11:10:13 AM.webm](https://github.com/user-attachments/assets/34ebbaa0-8f71-424f-b93d-2dc4c032ac66)
Co-authored-by: Andres Galindo <agalin920@gmail.com> Co-authored-by: Stuart Runyan <shrunyan@gmail.com> Co-authored-by: Allen Pigar <50983144+allenpigar@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Created by Github action --------- Co-authored-by: Andres Galindo <agalin920@gmail.com> Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com> Co-authored-by: Stuart Runyan <shrunyan@gmail.com> Co-authored-by: Allen Pigar <50983144+allenpigar@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SEO TabBugs
|
Bugs
Figma VQAPrimarily only tiny fixes needed with one material theme change. Enhancements
UI Updates
|
Web Engine Changes RequiredWe need the following changes made to Web Engine for the Twitter Card and Facebook Card previews
@giseleblair can assist with questions regarding these changes. |
@shrunyan this material repo PR is also a dependency for the SEO tab changes |
Resolves the ff: - #2933 (comment) - #2933 (comment)
Co-authored-by: Andres Galindo <agalin920@gmail.com> Co-authored-by: Stuart Runyan <shrunyan@gmail.com> Co-authored-by: Allen Pigar <50983144+allenpigar@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Created by Github action --------- Co-authored-by: Andres Galindo <agalin920@gmail.com> Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com> Co-authored-by: Stuart Runyan <shrunyan@gmail.com> Co-authored-by: Allen Pigar <50983144+allenpigar@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Enhancement
Left Column:
Right Column:
Bug
|
Bug (Blocking Release)
Bugs (Not blocking the release)Error Blurb
Meta Description Field
Text to use to test if bug is fixed:
Preview Cards
|
Resolves vqa comments: - #2933 (comment) - #2933 (comment)
Co-authored-by: Andres Galindo <agalin920@gmail.com> Co-authored-by: Stuart Runyan <shrunyan@gmail.com> Co-authored-by: Allen Pigar <50983144+allenpigar@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Andres Galindo <agalin920@gmail.com> Co-authored-by: Stuart Runyan <shrunyan@gmail.com> Co-authored-by: Allen Pigar <50983144+allenpigar@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Andres Galindo <agalin920@gmail.com> Co-authored-by: Stuart Runyan <shrunyan@gmail.com> Co-authored-by: Allen Pigar <50983144+allenpigar@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This PR is now VQA Approved. Overall great work putting this all together @finnar-bin Note:
|
Post Release ChangesMay you please make two post release changes:
|
@zcolah I suggest creating a ticket for the post-release changes. This PR will be closed once it gets merged, that way it's easier to track those issues. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Andres Galindo <agalin920@gmail.com> Co-authored-by: Stuart Runyan <shrunyan@gmail.com>
Created by Github action --------- Co-authored-by: Andres Galindo <agalin920@gmail.com> Co-authored-by: Nar -- <28705606+finnar-bin@users.noreply.github.com> Co-authored-by: Stuart Runyan <shrunyan@gmail.com> Co-authored-by: Allen Pigar <50983144+allenpigar@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Created by Github action