Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the usage datasource url of postgresql (#4029) #4030

Merged
merged 1 commit into from
Mar 30, 2024
Merged

fix the usage datasource url of postgresql (#4029) #4030

merged 1 commit into from
Mar 30, 2024

Conversation

ak5w
Copy link
Contributor

@ak5w ak5w commented Mar 30, 2024

The demo url of posrgres from goctl tools usage is not correct. like this

The data source of database,like "root:password@tcp(127.0.0.1:3306)/database
seems copy from mysql side.

@ak5w ak5w mentioned this pull request Mar 30, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Mar 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.14%. Comparing base (2629636) to head (65041a8).
Report is 39 commits behind head on master.

Additional details and impacted files

see 253 files with indirect coverage changes

@kevwan kevwan added this pull request to the merge queue Mar 30, 2024
Merged via the queue into zeromicro:master with commit cf98729 Mar 30, 2024
6 checks passed
@kevwan kevwan linked an issue Mar 30, 2024 that may be closed by this pull request
The demo url of posrgres from goctl tools usage is not correct. #4029
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevwan kevwan kevwan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The demo url of posrgres from goctl tools usage is not correct.
2 participants
@ak5w @kevwan