Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The demo url of posrgres from goctl tools usage is not correct. #4029

Closed
ak5w opened this issue Mar 30, 2024 · 2 comments · Fixed by #4030
Closed

The demo url of posrgres from goctl tools usage is not correct. #4029

ak5w opened this issue Mar 30, 2024 · 2 comments · Fixed by #4030

Comments

@ak5w
Copy link
Contributor

ak5w commented Mar 30, 2024

Describe the bug
The demo url of posrgres from goctl tools usage is not correct. like this

The data source of database,like "root:password@tcp(127.0.0.1:3306)/database

seems copy from mysql side.

But the usage info from go-zero doc site is correct,
goctl model

To Reproduce

  1. env
    GOCTL_VERSION=1.6.3
  2. using below command
    goctl model pg datasource -h

Expected behavior
should provider a correct and friendly url info in usage, it is important for a beginner.
ak5w added a commit to ak5w/go-zero that referenced this issue Mar 30, 2024
@ak5w
fix the usage datasource url of postgresql (zeromicro#4029)
f9c5e2c
@ak5w
Copy link
Contributor Author

ak5w commented Mar 30, 2024

I raised a PR for fixing this.
fix the usage datasource url of postgresql (#4029)

kevwan pushed a commit to ak5w/go-zero that referenced this issue Mar 30, 2024
@ak5w @kevwan
fix the usage datasource url of postgresql (zeromicro#4029)
65041a8
github-merge-queue bot pushed a commit that referenced this issue Mar 30, 2024
@ak5w
fix the usage datasource url of postgresql (#4029) (#4030)
cf98729
@kevwan kevwan linked a pull request Mar 30, 2024 that will close this issue
fix the usage datasource url of postgresql (#4029) #4030
Merged
@kevwan
Copy link
Contributor

kevwan commented Mar 30, 2024

fixed by #4030

@kevwan kevwan closed this as completed Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix the usage datasource url of postgresql (#4029) ak5w/go-zero
2 participants
@kevwan @ak5w