-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic auth removal #362
Basic auth removal #362
Conversation
d2606f6
to
4f081e4
Compare
4f081e4
to
4012ec9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I knew basic auth involved a bunch of code, but I'm amazed at the 3k lines that you were able to get rid of.
Well, Basic Auth isn't that huge, it's only some 640 lines. Most of the 3k comes from OAuth 1.0a removal. Since the two PR build on top of each other, and Github counts the total changes wrt the master branch, it looks like this PR is really 3k.
|
9549bef
to
c81b54e
Compare
c81b54e
to
439e845
Compare
Merging only after #354 is done.