Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic auth removal #362

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Conversation

mmd-osm
Copy link
Collaborator

@mmd-osm mmd-osm commented Feb 17, 2024

Merging only after #354 is done.

@mmd-osm mmd-osm linked an issue Feb 17, 2024 that may be closed by this pull request
@mmd-osm mmd-osm changed the title Remove Basic auth Basic auth removal Feb 17, 2024
@mmd-osm mmd-osm added this to the v0.9.0 milestone Feb 17, 2024
@mmd-osm mmd-osm force-pushed the patch/basicauth_removal branch from d2606f6 to 4f081e4 Compare February 18, 2024 19:54
@mmd-osm mmd-osm changed the base branch from oauth_removal to master March 17, 2024 21:47
@mmd-osm mmd-osm force-pushed the patch/basicauth_removal branch from 4f081e4 to 4012ec9 Compare March 22, 2024 21:43
Copy link
Contributor

@pnorman pnorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I knew basic auth involved a bunch of code, but I'm amazed at the 3k lines that you were able to get rid of.

@mmd-osm
Copy link
Collaborator Author

mmd-osm commented Mar 22, 2024

Well, Basic Auth isn't that huge, it's only some 640 lines. Most of the 3k comes from OAuth 1.0a removal. Since the two PR build on top of each other, and Github counts the total changes wrt the master branch, it looks like this PR is really 3k.

image

9549befa21bcfa16f00f8c89d12822430f0c77ae
 .github/workflows/codeql.yml                       |   2 +-
 CMakeLists.txt                                     |   1 -
 cmake/FindArgon2.cmake                             |  47 -----
 docker/debian/Dockerfile_bookworm                  |   4 +-
 docker/debian/Dockerfile_trixie                    |   4 +-
 docker/ubuntu/Dockerfile                           |   4 +-
 docker/ubuntu/Dockerfile2204                       |   4 +-
 .../backend/apidb/readonly_pgsql_selection.hpp     |   1 -
 include/cgimap/basicauth.hpp                       |  45 -----
 include/cgimap/data_selection.hpp                  |   5 -
 include/cgimap/options.hpp                         |  14 --
 include/cgimap/process_request.hpp                 |   1 -
 src/CMakeLists.txt                                 |   2 -
 src/backend/apidb/readonly_pgsql_selection.cpp     |  36 ----
 src/basicauth.cpp                                  | 193 -------------------
 src/main.cpp                                       |   1 -
 src/options.cpp                                    |   8 -
 src/process_request.cpp                            |   8 +-
 test/CMakeLists.txt                                |  19 --
 test/staticxml.cpp                                 |   1 -
 test/test_apidb_backend_changeset_uploads.cpp      |  37 ++--
 test/test_apidb_backend_changesets.cpp             |  51 ++---
 test/test_basicauth.cpp                            | 213 ---------------------
 test/test_empty_selection.hpp                      |   1 -
 test/test_parse_options.cpp                        |   2 -
 25 files changed, 64 insertions(+), 640 deletions(-)

@mmd-osm mmd-osm force-pushed the patch/basicauth_removal branch from 9549bef to c81b54e Compare March 23, 2024 09:16
@mmd-osm mmd-osm merged commit 6a3692c into zerebubuth:master Apr 19, 2024
6 checks passed
@mmd-osm mmd-osm deleted the patch/basicauth_removal branch July 13, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove support for OAuth 1.0a and Basic Auth
2 participants