OAuth 1.0a removal #354
Merged
OAuth 1.0a removal #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmd-osm
force-pushed
the
patch/oauth10a_removal
branch
from
23b85b8 to
12bfe63
Compare
mmd-osm
force-pushed
the
patch/oauth10a_removal
branch
from
12bfe63 to
445d65d
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
mmd-osm
force-pushed
the
patch/oauth10a_removal
branch
from
d4158f9 to
9975486
Compare
This was referenced Dec 23, 2023
mmd-osm
force-pushed
the
patch/oauth10a_removal
branch
2 times, most recently
from
30e30b7 to
0749508
Compare
mmd-osm
force-pushed
the
patch/oauth10a_removal
branch
from
0749508 to
5359381
Compare
Merged
mmd-osm
force-pushed
the
patch/oauth10a_removal
branch
from
5359381 to
4012ec9
Compare
mmd-osm
force-pushed
the
patch/oauth10a_removal
branch
from
4012ec9 to
888e35b
Compare
|
We will wait a bit more for Organic Maps to merge their OAuth 1.0a -> OAuth 2.0 PR. Target date is after their April release, so probably within in the next couple of weeks. Otherwise merging this PR will break their unit tests on master.apis.dev.openstreetmap.org. |
|
organicmaps/organicmaps#7333 has been merged in the meantime -> "waiting downstream" label removed. Merging is planned shortly after the 0.9.1 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request completely removes OAuth 1.0a, including all test cases, config options, manual page details, etc.
Redaction related unit tests which were based on OAuth 1.0a before are now using OAuth 2.0.
As a side effect of this PR, we're reducing the number of db connections from 3 to 2 per process.
Create a new release
0.8.10.9.0 before merging this PR.Don't merge right away, since it would impact some unit tests on master.apis.dev.