Add nRF9161 SoC variant to CTCC board #82814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kowalewskijan
force-pushed
the
add-ctcc-nrf9161
branch
2 times, most recently
from
cc6e922 to
1eb4434
Compare
zephyrbot
added
area: Continuous Integration
area: Coding Guidelines
zephyrbot
requested review from
carlescufi,
fabiobaltieri,
jfischer-no,
kartben,
keith-zephyr,
nashif,
simhein and
stephanosio
kowalewskijan
force-pushed
the
add-ctcc-nrf9161
branch
from
1eb4434 to
2bbacfa
Compare
nordicjm
requested changes
Dec 11, 2024
kowalewskijan
force-pushed
the
add-ctcc-nrf9161
branch
5 times, most recently
from
55876fd to
328bab8
Compare
jfischer-no
previously requested changes
Dec 12, 2024
Add missing configurations to yaml and device-tree. Signed-off-by: Jan Kowalewski <jkowalewski@cthings.co>
kowalewskijan
force-pushed
the
add-ctcc-nrf9161
branch
from
328bab8 to
8aa092f
Compare
kowalewskijan
changed the title
Add support for CTHINGS.CO Connectivity Card with nRF9161 SoC variant. Signed-off-by: Jan Kowalewski <jkowalewski@cthings.co>
kowalewskijan
force-pushed
the
add-ctcc-nrf9161
branch
3 times, most recently
from
c72e8bb to
5d3dd47
Compare
nordicjm
previously approved these changes
Dec 12, 2024
kartben
requested changes
Dec 13, 2024
kowalewskijan
force-pushed
the
add-ctcc-nrf9161
branch
from
5d3dd47 to
d0efa98
Compare
|
@kowalewskijan can you add an entry into the Maintainers file for |
They are not a collaborator so they should not |
nordicjm
previously approved these changes
Dec 16, 2024
|
@kartben I applied the changes you requested. PTAL |
fabiobaltieri
previously approved these changes
Dec 16, 2024
kartben
requested changes
Dec 16, 2024
There was a problem hiding this comment.
some doc issues left
fyi you may always check how documentation looks like in CI, here this would be https://builds.zephyrproject.io/zephyr/pr/82814/docs/boards/ct/ctcc/doc/index.html
* Add documentation about nRF9161 SoC variant * Modify example apps to include both nRF9161 and nRF52840 * Switch from DFU to MCUmgr in example apps Signed-off-by: Jan Kowalewski <jkowalewski@cthings.co>
kowalewskijan
dismissed stale reviews from fabiobaltieri and nordicjm
via
5551ac6
kowalewskijan
force-pushed
the
add-ctcc-nrf9161
branch
from
d0efa98 to
5551ac6
Compare
kartben
approved these changes
Dec 16, 2024
nordicjm
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds CTHINGS.CO Connectivity Card nRF9161 SoC variant and switches example app from DFU to mcumgr.
What I'm not sure about is how to handle additional
CONFIG_*from MCUboot, I added them initially to allowed list in the compliance script, if there is other way of mentioning these configs in the board documentation without changing the script, please let me know.