Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

soc: arm: npcx: fix clock reference of APB4/FIU1 buses #65204

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

MulinChao
Copy link
Collaborator

This CL fixes the clock reference of APB4/FIU1 buses by introducing new Kconfig options.

This CL fixes the clock reference of APB4/FIU1 buses by introducing new
Kconfig options.

Signed-off-by: Mulin Chao <mlchao@nuvoton.com>
@fabiobaltieri fabiobaltieri added the Hotfix Fix for issues blocking development, i.e. CI issues, tests failing in CI, etc. label Nov 15, 2023
Copy link
Contributor

@keith-zephyr keith-zephyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed the UART is working on board using the NPCX9.

@MulinChao
Copy link
Collaborator Author

On our side, it also passed the stress test of 2500 times of cold boot on ADL-Chromebook. No broken console character symptoms occur.

@fabiobaltieri fabiobaltieri merged commit 76b0aab into zephyrproject-rtos:main Nov 16, 2023
26 checks passed
coreboot-bot pushed a commit to coreboot/zephyr-cros that referenced this pull request Nov 16, 2023
This CL fixes the clock reference of APB4/FIU1 buses by introducing new
Kconfig options.

Signed-off-by: Mulin Chao <mlchao@nuvoton.com>
(cherry picked from commit 76b0aab)

Manaul cherry-pick of:
zephyrproject-rtos/zephyr#65204

This needs to be merged with a reland of chromium:5016743 to
avoid a merge conflict.

BUG=b:310935269
TEST=zmake build -a.  Verify UART on Brya (npcx9 device)

Change-Id: I66272f29025fd893e31fd954e28518f5b7b9d7b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/zephyr/+/5037870
Tested-by: Keith Short <keithshort@chromium.org>
Reviewed-by: Al Semjonovs <asemjonovs@google.com>
Commit-Queue: Keith Short <keithshort@chromium.org>
Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Clock Control Hotfix Fix for issues blocking development, i.e. CI issues, tests failing in CI, etc. platform: Nuvoton NPCX Nuvoton NPCX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants