Consolidate tests for InputFilterInterface #57

Maks3w · 2015-09-03T06:33:14Z

This PR consolidate many test in a more visual way and less coupled from specific implementations.

Fixes:

Fix exception name
Fix $this->data:ArrayAccess fail when hasUnknown/getUnknown

Added:

Feature: Allow replace input with the same types allowed in add method

…methods)

Also clean the test from old test (context is already consolidate), use mocks and data provider

InputFilter allow more types of inputs (specification arrays) and have sense to allow it too in replace method

…essages, getXInputs)

Used in validateInputs docblock

Following interface contract

Consolidate tests for InputFilterInterface

Forward port #57

Close #57

Includes these changes: - [14: NotEmpty validator doesn't override the required attribute](zendframework#14) - [16: BC in validators context value](zendframework#16) - [22: Missing required field with fallback does not return input in getValidInput](zendframework#22) - [24: Fix loop validation input context is mutable](zendframework#24) - [25: Fix missing optional fields should not be validated](zendframework#25) - [32: Promote HHVM](zendframework#32) - [36: Fix docblocks declared as regular comment block](zendframework#36) - [40: Remove test about Input setters permutation](zendframework#40) - [41: Refactor tests for group 7448 as a data set matrix](zendframework#41) - [42: Consolidate InputFilterPluginManager tests](zendframework#42) - [43: Consolidate Factory tests + Fixes](zendframework#43) - [44: Consolidate of InputInterface::merge and Fix unsafe merge](zendframework#44) - [45: When merge Inputs don't merge values if source does not have one.](zendframework#45) - [46: Expand test matrix with nonempty value scenarios](zendframework#46) - [47: Feature/minor test improvements](zendframework#47) - [48: Empty values + Allow Empty + Not continue if empty is always true](zendframework#48) - [49: Add tests for exceptions and improve some messages](zendframework#49) - [50: Optional fields without value should be valid ](zendframework#50) - [51: Optional input without value are valid](zendframework#51) - [52: Fix merge two inputs without value, result 'has value' flag should be false](zendframework#52) - [53: Tune NonEmpty options for detect the expected empty values](zendframework#53) - [55: Make symmetric the scenarios when required is true/false](zendframework#55) - [56: Hotfix/minor changes](zendframework#56) - [57: Consolidate tests for InputFilterInterface](zendframework#57) - [61: Provide NotEmpty::IS&zendframework#95;EMPTY validation message for required input](zendframework#61) - [63: Ensure custom error messages are used for required missing inputs](zendframework#63) - [64: Feature/test cleanup](zendframework#64)

Includes these changes: - [14: NotEmpty validator doesn't override the required attribute](zendframework#14) - [16: BC in validators context value](zendframework#16) - [24: Fix loop validation input context is mutable](zendframework#24) - [25: Fix missing optional fields should not be validated](zendframework#25) - [26: Deprecate magic logic for auto attaching a NonEmpty validator with breakChainOnFailure = true](zendframework#26) - [31: Update the InputFilterInterface::add docblock to match existing, shipped implementations](zendframework#31) - [32: Promote HHVM](zendframework#32) - [36: Fix docblocks declared as regular comment block](zendframework#36) - [40: Remove test about Input setters permutation](zendframework#40) - [41: Refactor tests for group 7448 as a data set matrix](zendframework#41) - [42: Consolidate InputFilterPluginManager tests](zendframework#42) - [43: Consolidate Factory tests + Fixes](zendframework#43) - [44: Consolidate of InputInterface::merge and Fix unsafe merge](zendframework#44) - [45: When merge Inputs don't merge values if source does not have one.](zendframework#45) - [46: Expand test matrix with nonempty value scenarios](zendframework#46) - [47: Feature/minor test improvements](zendframework#47) - [48: Empty values + Allow Empty + Not continue if empty is always true](zendframework#48) - [49: Add tests for exceptions and improve some messages](zendframework#49) - [50: Optional fields without value should be valid ](zendframework#50) - [51: Optional input without value are valid](zendframework#51) - [52: Fix merge two inputs without value, result 'has value' flag should be false](zendframework#52) - [56: Hotfix/minor changes](zendframework#56) - [57: Consolidate tests for InputFilterInterface](zendframework#57) - [61: Provide NotEmpty::IS&zendframework#95;EMPTY validation message for required input](zendframework#61) - [63: Ensure custom error messages are used for required missing inputs](zendframework#63) - [64: Feature/test cleanup](zendframework#64)

Includes these changes: - [14: NotEmpty validator doesn't override the required attribute](zendframework#14) - [16: BC in validators context value](zendframework#16) - [24: Fix loop validation input context is mutable](zendframework#24) - [25: Fix missing optional fields should not be validated](zendframework#25) - [26: Deprecate magic logic for auto attaching a NonEmpty validator with breakChainOnFailure = true](zendframework#26) - [31: Update the InputFilterInterface::add docblock to match existing, shipped implementations](zendframework#31) - [36: Fix docblocks declared as regular comment block](zendframework#36) - [40: Remove test about Input setters permutation](zendframework#40) - [41: Refactor tests for group 7448 as a data set matrix](zendframework#41) - [42: Consolidate InputFilterPluginManager tests](zendframework#42) - [43: Consolidate Factory tests + Fixes](zendframework#43) - [44: Consolidate of InputInterface::merge and Fix unsafe merge](zendframework#44) - [45: When merge Inputs don't merge values if source does not have one.](zendframework#45) - [46: Expand test matrix with nonempty value scenarios](zendframework#46) - [47: Feature/minor test improvements](zendframework#47) - [48: Empty values + Allow Empty + Not continue if empty is always true](zendframework#48) - [49: Add tests for exceptions and improve some messages](zendframework#49) - [50: Optional fields without value should be valid ](zendframework#50) - [51: Optional input without value are valid](zendframework#51) - [52: Fix merge two inputs without value, result 'has value' flag should be false](zendframework#52) - [56: Hotfix/minor changes](zendframework#56) - [57: Consolidate tests for InputFilterInterface](zendframework#57) - [61: Provide NotEmpty::IS&zendframework#95;EMPTY validation message for required input](zendframework#61) - [63: Ensure custom error messages are used for required missing inputs](zendframework#63) - [64: Feature/test cleanup](zendframework#64)

Includes these changes: - [14: NotEmpty validator doesn't override the required attribute](zendframework/zend-inputfilter#14) - [16: BC in validators context value](zendframework/zend-inputfilter#16) - [24: Fix loop validation input context is mutable](zendframework/zend-inputfilter#24) - [25: Fix missing optional fields should not be validated](zendframework/zend-inputfilter#25) - [26: Deprecate magic logic for auto attaching a NonEmpty validator with breakChainOnFailure = true](zendframework/zend-inputfilter#26) - [31: Update the InputFilterInterface::add docblock to match existing, shipped implementations](zendframework/zend-inputfilter#31) - [36: Fix docblocks declared as regular comment block](zendframework/zend-inputfilter#36) - [40: Remove test about Input setters permutation](zendframework/zend-inputfilter#40) - [41: Refactor tests for group 7448 as a data set matrix](zendframework/zend-inputfilter#41) - [42: Consolidate InputFilterPluginManager tests](zendframework/zend-inputfilter#42) - [43: Consolidate Factory tests + Fixes](zendframework/zend-inputfilter#43) - [44: Consolidate of InputInterface::merge and Fix unsafe merge](zendframework/zend-inputfilter#44) - [45: When merge Inputs don't merge values if source does not have one.](zendframework/zend-inputfilter#45) - [46: Expand test matrix with nonempty value scenarios](zendframework/zend-inputfilter#46) - [47: Feature/minor test improvements](zendframework/zend-inputfilter#47) - [48: Empty values + Allow Empty + Not continue if empty is always true](zendframework/zend-inputfilter#48) - [49: Add tests for exceptions and improve some messages](zendframework/zend-inputfilter#49) - [50: Optional fields without value should be valid ](zendframework/zend-inputfilter#50) - [51: Optional input without value are valid](zendframework/zend-inputfilter#51) - [52: Fix merge two inputs without value, result 'has value' flag should be false](zendframework/zend-inputfilter#52) - [56: Hotfix/minor changes](zendframework/zend-inputfilter#56) - [57: Consolidate tests for InputFilterInterface](zendframework/zend-inputfilter#57) - [61: Provide NotEmpty::IS_EMPTY validation message for required input](zendframework/zend-inputfilter#61) - [63: Ensure custom error messages are used for required missing inputs](zendframework/zend-inputfilter#63) - [64: Feature/test cleanup](zendframework/zend-inputfilter#64)

Consolidate tests for InputFilterInterface (add/has/get/remove/count …

826d8c4

…methods)

Maks3w added this to the 2.4.8 milestone Sep 3, 2015

Maks3w added 2 commits September 3, 2015 08:34

Remove legacy tests

161aef7

Test for BaseInputFilter replace

6f1bba6

Maks3w force-pushed the feature/baseInputFilter-enhancements branch from faad4e6 to 6f1bba6 Compare September 3, 2015 06:36

Maks3w added 8 commits September 3, 2015 08:51

Improve readibility of test data provider

70bb676

CS: Remove BaseInputFilter alias and use setUp

fa4db2c

CS: Data set table

75913bb

Make InputFilterTest extend from BaseInputFilterTest

b5b2c68

Also clean the test from old test (context is already consolidate), use mocks and data provider

Fix exception name

11dff96

Feature: Allow replace input with the same types allowed in add method

97bc9a4

InputFilter allow more types of inputs (specification arrays) and have sense to allow it too in replace method

Improve exception description

8fda1dc

CS Fix

8589183

Maks3w force-pushed the feature/baseInputFilter-enhancements branch 4 times, most recently from 81098e8 to b6e59c9 Compare September 3, 2015 09:34

Maks3w added the WIP label Sep 3, 2015

Maks3w added 5 commits September 3, 2015 17:00

CS

f8057ce

Move test to the correct class

e3f4c38

Consolidate tests for InputFilterInterface (isValid, getXValues, getM…

4cafeed

…essages, getXInputs)

Remove legacy tests

1d88c70

Add asserts for unknown fields

2d18e15

Maks3w force-pushed the feature/baseInputFilter-enhancements branch from 8a13a80 to 2d18e15 Compare September 3, 2015 15:51

Fix $this->data:ArrayAccess fail when hasUnknown/getUnknown

bf952c4

Maks3w added the bug label Sep 3, 2015

Maks3w added 3 commits September 3, 2015 18:07

CS fix

7938d79

Restore use.

2dac20e

Used in validateInputs docblock

Add cases for nested InputFilter objects

d7087e2

Maks3w force-pushed the feature/baseInputFilter-enhancements branch from 87e5f3a to d7087e2 Compare September 3, 2015 16:59

Maks3w added 2 commits September 3, 2015 19:06

Fix CollectionInputFilter::setData must return $this

da2bd8e

Following interface contract

Print useful error messages for isValid assertions

ed43e42

weierophinney removed the WIP label Sep 3, 2015

weierophinney self-assigned this Sep 3, 2015

weierophinney added a commit that referenced this pull request Sep 3, 2015

Merge pull request #57 from Maks3w/feature/baseInputFilter-enhancements

e702787

Consolidate tests for InputFilterInterface

weierophinney added a commit that referenced this pull request Sep 3, 2015

Merge branch 'hotfix/57' into develop

8be24d4

Forward port #57

weierophinney merged commit ed43e42 into zendframework:master Sep 3, 2015

weierophinney added a commit that referenced this pull request Sep 3, 2015

Merge branch 'hotfix/57'

8b29f7f

Close #57

Maks3w deleted the feature/baseInputFilter-enhancements branch September 3, 2015 18:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Consolidate tests for InputFilterInterface #57

Consolidate tests for InputFilterInterface #57

Maks3w commented Sep 3, 2015

Consolidate tests for InputFilterInterface #57

Consolidate tests for InputFilterInterface #57

Conversation

Maks3w commented Sep 3, 2015