Refactor tests for group 7448 as a data set matrix #41

Maks3w · 2015-08-30T10:26:10Z

Refactor tests as a data set matrix which is more visual
Fix a case where empty values in ArrayInput does not work in the same way as Input does when is not required

This development is on top of #40

Maks3w · 2015-09-01T08:13:14Z

test/InputTest.php

+            // Description => [$isRequired, $allowEmpty, $continueIfEmpty, $validator, [$values], $expectedIsValid, $expectedMessages]
+            'Required: T; AEmpty: T; CIEmpty: T; Validator: T' => [ $isRequired,  $aEmpty,  $cIEmpty, $validatorValid  , $emptyValues,  $isValid, []],
+            'Required: T; AEmpty: T; CIEmpty: T; Validator: F' => [ $isRequired,  $aEmpty,  $cIEmpty, $validatorInvalid, $emptyValues, !$isValid, $validatorMsg],
+            'Required: T; AEmpty: T; CIEmpty: F; Validator: X' => [ $isRequired,  $aEmpty, !$cIEmpty, $validatorNotCall, $emptyValues,  $isValid, []],


Makes sense to have allow_empty:true and continue_if_empty:false?

No validator will be invoked ever. Will be ever true no matter what value was set.

Yes, it makes sense. Consider the following scenario:

Address 2 is required, and must be submitted.

An empty Address 2 is acceptable

But a non-empty Address 2 needs to pass certain validation criteria.

That's the sort of scenario that uses those three criteria with those three values.

Will be ever true no matter what value was set.

Not true. If a value is present, it will be passed to attached validators. So, the set of valid values are:

Empty values

Non-empty values that pass the validation chain.

Non-Empty Address2 never hit the validator due Continue:False

See the test has an assertion for ensure is never call

All these test cases are duplicated with 7448

Refactor tests for group 7448 as a data set matrix

Close #41

Forward port #41

Includes these changes: - [14: NotEmpty validator doesn't override the required attribute](zendframework#14) - [16: BC in validators context value](zendframework#16) - [22: Missing required field with fallback does not return input in getValidInput](zendframework#22) - [24: Fix loop validation input context is mutable](zendframework#24) - [25: Fix missing optional fields should not be validated](zendframework#25) - [32: Promote HHVM](zendframework#32) - [36: Fix docblocks declared as regular comment block](zendframework#36) - [40: Remove test about Input setters permutation](zendframework#40) - [41: Refactor tests for group 7448 as a data set matrix](zendframework#41) - [42: Consolidate InputFilterPluginManager tests](zendframework#42) - [43: Consolidate Factory tests + Fixes](zendframework#43) - [44: Consolidate of InputInterface::merge and Fix unsafe merge](zendframework#44) - [45: When merge Inputs don't merge values if source does not have one.](zendframework#45) - [46: Expand test matrix with nonempty value scenarios](zendframework#46) - [47: Feature/minor test improvements](zendframework#47) - [48: Empty values + Allow Empty + Not continue if empty is always true](zendframework#48) - [49: Add tests for exceptions and improve some messages](zendframework#49) - [50: Optional fields without value should be valid ](zendframework#50) - [51: Optional input without value are valid](zendframework#51) - [52: Fix merge two inputs without value, result 'has value' flag should be false](zendframework#52) - [53: Tune NonEmpty options for detect the expected empty values](zendframework#53) - [55: Make symmetric the scenarios when required is true/false](zendframework#55) - [56: Hotfix/minor changes](zendframework#56) - [57: Consolidate tests for InputFilterInterface](zendframework#57) - [61: Provide NotEmpty::IS&zendframework#95;EMPTY validation message for required input](zendframework#61) - [63: Ensure custom error messages are used for required missing inputs](zendframework#63) - [64: Feature/test cleanup](zendframework#64)

Includes these changes: - [14: NotEmpty validator doesn't override the required attribute](zendframework#14) - [16: BC in validators context value](zendframework#16) - [24: Fix loop validation input context is mutable](zendframework#24) - [25: Fix missing optional fields should not be validated](zendframework#25) - [26: Deprecate magic logic for auto attaching a NonEmpty validator with breakChainOnFailure = true](zendframework#26) - [31: Update the InputFilterInterface::add docblock to match existing, shipped implementations](zendframework#31) - [32: Promote HHVM](zendframework#32) - [36: Fix docblocks declared as regular comment block](zendframework#36) - [40: Remove test about Input setters permutation](zendframework#40) - [41: Refactor tests for group 7448 as a data set matrix](zendframework#41) - [42: Consolidate InputFilterPluginManager tests](zendframework#42) - [43: Consolidate Factory tests + Fixes](zendframework#43) - [44: Consolidate of InputInterface::merge and Fix unsafe merge](zendframework#44) - [45: When merge Inputs don't merge values if source does not have one.](zendframework#45) - [46: Expand test matrix with nonempty value scenarios](zendframework#46) - [47: Feature/minor test improvements](zendframework#47) - [48: Empty values + Allow Empty + Not continue if empty is always true](zendframework#48) - [49: Add tests for exceptions and improve some messages](zendframework#49) - [50: Optional fields without value should be valid ](zendframework#50) - [51: Optional input without value are valid](zendframework#51) - [52: Fix merge two inputs without value, result 'has value' flag should be false](zendframework#52) - [56: Hotfix/minor changes](zendframework#56) - [57: Consolidate tests for InputFilterInterface](zendframework#57) - [61: Provide NotEmpty::IS&zendframework#95;EMPTY validation message for required input](zendframework#61) - [63: Ensure custom error messages are used for required missing inputs](zendframework#63) - [64: Feature/test cleanup](zendframework#64)

Includes these changes: - [14: NotEmpty validator doesn't override the required attribute](zendframework#14) - [16: BC in validators context value](zendframework#16) - [24: Fix loop validation input context is mutable](zendframework#24) - [25: Fix missing optional fields should not be validated](zendframework#25) - [26: Deprecate magic logic for auto attaching a NonEmpty validator with breakChainOnFailure = true](zendframework#26) - [31: Update the InputFilterInterface::add docblock to match existing, shipped implementations](zendframework#31) - [36: Fix docblocks declared as regular comment block](zendframework#36) - [40: Remove test about Input setters permutation](zendframework#40) - [41: Refactor tests for group 7448 as a data set matrix](zendframework#41) - [42: Consolidate InputFilterPluginManager tests](zendframework#42) - [43: Consolidate Factory tests + Fixes](zendframework#43) - [44: Consolidate of InputInterface::merge and Fix unsafe merge](zendframework#44) - [45: When merge Inputs don't merge values if source does not have one.](zendframework#45) - [46: Expand test matrix with nonempty value scenarios](zendframework#46) - [47: Feature/minor test improvements](zendframework#47) - [48: Empty values + Allow Empty + Not continue if empty is always true](zendframework#48) - [49: Add tests for exceptions and improve some messages](zendframework#49) - [50: Optional fields without value should be valid ](zendframework#50) - [51: Optional input without value are valid](zendframework#51) - [52: Fix merge two inputs without value, result 'has value' flag should be false](zendframework#52) - [56: Hotfix/minor changes](zendframework#56) - [57: Consolidate tests for InputFilterInterface](zendframework#57) - [61: Provide NotEmpty::IS&zendframework#95;EMPTY validation message for required input](zendframework#61) - [63: Ensure custom error messages are used for required missing inputs](zendframework#63) - [64: Feature/test cleanup](zendframework#64)

Includes these changes: - [14: NotEmpty validator doesn't override the required attribute](zendframework/zend-inputfilter#14) - [16: BC in validators context value](zendframework/zend-inputfilter#16) - [24: Fix loop validation input context is mutable](zendframework/zend-inputfilter#24) - [25: Fix missing optional fields should not be validated](zendframework/zend-inputfilter#25) - [26: Deprecate magic logic for auto attaching a NonEmpty validator with breakChainOnFailure = true](zendframework/zend-inputfilter#26) - [31: Update the InputFilterInterface::add docblock to match existing, shipped implementations](zendframework/zend-inputfilter#31) - [36: Fix docblocks declared as regular comment block](zendframework/zend-inputfilter#36) - [40: Remove test about Input setters permutation](zendframework/zend-inputfilter#40) - [41: Refactor tests for group 7448 as a data set matrix](zendframework/zend-inputfilter#41) - [42: Consolidate InputFilterPluginManager tests](zendframework/zend-inputfilter#42) - [43: Consolidate Factory tests + Fixes](zendframework/zend-inputfilter#43) - [44: Consolidate of InputInterface::merge and Fix unsafe merge](zendframework/zend-inputfilter#44) - [45: When merge Inputs don't merge values if source does not have one.](zendframework/zend-inputfilter#45) - [46: Expand test matrix with nonempty value scenarios](zendframework/zend-inputfilter#46) - [47: Feature/minor test improvements](zendframework/zend-inputfilter#47) - [48: Empty values + Allow Empty + Not continue if empty is always true](zendframework/zend-inputfilter#48) - [49: Add tests for exceptions and improve some messages](zendframework/zend-inputfilter#49) - [50: Optional fields without value should be valid ](zendframework/zend-inputfilter#50) - [51: Optional input without value are valid](zendframework/zend-inputfilter#51) - [52: Fix merge two inputs without value, result 'has value' flag should be false](zendframework/zend-inputfilter#52) - [56: Hotfix/minor changes](zendframework/zend-inputfilter#56) - [57: Consolidate tests for InputFilterInterface](zendframework/zend-inputfilter#57) - [61: Provide NotEmpty::IS_EMPTY validation message for required input](zendframework/zend-inputfilter#61) - [63: Ensure custom error messages are used for required missing inputs](zendframework/zend-inputfilter#63) - [64: Feature/test cleanup](zendframework/zend-inputfilter#64)

Maks3w added the enhancement label Aug 30, 2015

Maks3w force-pushed the feature/test-matrix branch 3 times, most recently from 7298aad to 2c0e7e5 Compare August 30, 2015 13:05

Maks3w added this to the 2.4.8 milestone Aug 30, 2015

Maks3w added bug WIP labels Aug 30, 2015

Maks3w force-pushed the feature/test-matrix branch 3 times, most recently from c61e959 to 539ee60 Compare August 31, 2015 11:35

Maks3w removed the WIP label Aug 31, 2015

Maks3w force-pushed the feature/test-matrix branch 2 times, most recently from 185a766 to 65c9b67 Compare August 31, 2015 12:16

Maks3w reviewed Sep 1, 2015
View reviewed changes

Maks3w added 5 commits September 1, 2015 20:54

Use setValueProvider instead emptyValuesProvider where possible

cbedb18

Remove tests supersede by group 7448

095e011

All these test cases are duplicated with 7448

Refactor tests for group 7448 as a data set matrix

ebb0663

Fix ArrayInput when Required: F; AEmpty: F; CIEmpty: F; VChain: NotCall

4e7068b

Remove old tests

3c811f5

Maks3w force-pushed the feature/test-matrix branch from 29b5680 to 3c811f5 Compare September 1, 2015 18:55

weierophinney merged commit 3c811f5 into zendframework:master Sep 1, 2015

weierophinney added a commit that referenced this pull request Sep 1, 2015

Merge pull request #41 from Maks3w/feature/test-matrix

04f08a8

Refactor tests for group 7448 as a data set matrix

weierophinney added a commit that referenced this pull request Sep 1, 2015

Merge branch 'hotfix/41'

67c68c8

Close #41

weierophinney added a commit that referenced this pull request Sep 1, 2015

Merge branch 'hotfix/41' into develop

5e2e21d

Forward port #41

Maks3w deleted the feature/test-matrix branch September 1, 2015 21:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor tests for group 7448 as a data set matrix #41

Refactor tests for group 7448 as a data set matrix #41

Maks3w commented Aug 30, 2015

Maks3w Sep 1, 2015

weierophinney Sep 1, 2015

weierophinney Sep 1, 2015

Maks3w Sep 1, 2015

Refactor tests for group 7448 as a data set matrix #41

Refactor tests for group 7448 as a data set matrix #41

Conversation

Maks3w commented Aug 30, 2015

Maks3w Sep 1, 2015

Choose a reason for hiding this comment

weierophinney Sep 1, 2015

Choose a reason for hiding this comment

weierophinney Sep 1, 2015

Choose a reason for hiding this comment

Maks3w Sep 1, 2015

Choose a reason for hiding this comment