-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for mapping booleans #64
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -91,6 +91,33 @@ public extension Dictionary { | |
return property(name) | ||
} | ||
|
||
/// Map value using key to String | ||
/// | ||
/// - Parameter name: The name of the key. | ||
/// - Returns: An optional String | ||
func boolean(_ name: String) -> Bool? { | ||
guard let key = name as? Key else { | ||
return nil | ||
} | ||
|
||
if let string = self[key] as? String { | ||
|
||
if ["true", "1"].contains(string.lowercased()) { | ||
return true | ||
} else if ["false", "0"].contains(string.lowercased()) { | ||
return false | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @onmyway133 what do you think about this? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it is good 👍 |
||
|
||
return nil | ||
} else if let number = self[key] as? NSNumber { | ||
return number.boolValue | ||
} else if let boolean = self[key] as? Bool { | ||
return boolean | ||
} else { | ||
return nil | ||
} | ||
} | ||
|
||
/// A generic method that maps a value from a key to a specific type. | ||
/// | ||
/// - Parameters: | ||
|
@@ -110,6 +137,8 @@ public extension Dictionary { | |
return value | ||
} else { | ||
switch ofType { | ||
case is Bool.Type: | ||
return boolean(forKey) as? T | ||
case is Double.Type: | ||
return double(forKey) as? T | ||
case is Float.Type: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There 's another case of "1", "0"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah we could add that :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blame the backend 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assertFailure("Contact your backend devs because something is clearly not correct here.")