Add support for mapping booleans #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add method for mapping boolean value from a Dictionary.
onmyway133
reviewed
May 11, 2017
| return nil | ||
| } | ||
|
|
||
| if let string = self[key] as? String { |
There was a problem hiding this comment.
There 's another case of "1", "0"
There was a problem hiding this comment.
Yeah we could add that :)
There was a problem hiding this comment.
assertFailure("Contact your backend devs because something is clearly not correct here.")
onmyway133
approved these changes
May 11, 2017
Consider "true" and "1" to be equal to true and "false", "0" to be false when mapping booleans. Otherwise return nil.
zenangst
commented
May 11, 2017
| return true | ||
| } else if ["false", "0"].contains(string.lowercased()) { | ||
| return false | ||
| } |
There was a problem hiding this comment.
@onmyway133 what do you think about this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add method for mapping boolean value from a Dictionary.