Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add threads:off to the config file #662

Merged
merged 1 commit into from
Jul 5, 2022
Merged

add threads:off to the config file #662

merged 1 commit into from
Jul 5, 2022

Conversation

ringabout
Copy link
Contributor

Hello, Nim v2 is going to make threads:on default, which was discussed here: nim-lang/RFCs#361 and listed as the roadmap for 2.0: nim-lang/RFCs#437

I made a PR (nim-lang/Nim#19368) to enable threads, nitter gives in CI

  /Users/runner/work/Nim/Nim/pkgstemp/nitter/src/routes/preferences.nim(19, 10) template/generic instantiation of `router` from here
  /Users/runner/.nimble/pkgs/jester-0.5.0/jester.nim(1304, 35) template/generic instantiation of `async` from here
  /Users/runner/work/Nim/Nim/lib/pure/asyncmacro.nim(210, 31) Error: 'preferencesIter' is not GC-safe as it accesses 'defaultPrefs' which is a global using GC'ed memory

So I add threads:off to the config file.

@zedeus zedeus merged commit 0200cc2 into zedeus:master Jul 5, 2022
@zedeus
Copy link
Owner

zedeus commented Jul 5, 2022

Thanks!

joshieDo pushed a commit to joshieDo/nitter that referenced this pull request Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants