-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
default threads on #19368
default threads on #19368
Conversation
22c6871
to
fcfcc09
Compare
fcfcc09
to
bca98f0
Compare
ooh, nice :) I hope there's progress here, tried it back in #10781 and it was .. difficult. |
Quite so, I hope I can manage it eventually. |
ac2818c
to
d2ca3f4
Compare
d2ca3f4
to
05cf469
Compare
CI failure is partialy caused by #19372 |
in some cases enabling threads give up to 5% performance hit in singlethread applications. is this just accepted? |
Hi, it was discussed here: nim-lang/RFCs#361 and listed as the roadmap for 2.0: nim-lang/RFCs#437 IMO, it can hurt the performance of single-threaded application, they can use |
I have made PRs to nitter and nim-plotly => SciNim/nim-plotly#82 and zedeus/nitter#662 |
Co-authored-by: konsumlamm <44230978+konsumlamm@users.noreply.github.com>
Does |
If
It will require this DLL. But usually you should avoid usage of |
Does enabling |
@dom96 to be fair this DLL is not added as a dependency if the C compiler uses native Windows threads like VCC or statically link winpthread like tdm-gcc |
* default threads on * make rst gcsafe * ignore threads option for nimscript * threads off * use createShared for threads * test without threads * avr threds off * avr threads off * async threads off * threads off * fix ci * restore option * make CI pleased * fix ic tests * Update config.nims * add changelog * Update changelog.md Co-authored-by: konsumlamm <44230978+konsumlamm@users.noreply.github.com> Co-authored-by: konsumlamm <44230978+konsumlamm@users.noreply.github.com>
* default threads on * make rst gcsafe * ignore threads option for nimscript * threads off * use createShared for threads * test without threads * avr threds off * avr threads off * async threads off * threads off * fix ci * restore option * make CI pleased * fix ic tests * Update config.nims * add changelog * Update changelog.md Co-authored-by: konsumlamm <44230978+konsumlamm@users.noreply.github.com> Co-authored-by: konsumlamm <44230978+konsumlamm@users.noreply.github.com>
No description provided.