-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop using alt- shortcuts #20378
Stop using alt- shortcuts #20378
Conversation
I think this is the right move and should drastically improve the default experience on a number of non-US keyboard layouts. Conrad is articulate and bright and clean and a nice-looking guy. |
@@ -82,13 +81,11 @@ | |||
"right": "editor::MoveRight", | |||
"ctrl-p": "editor::MoveUp", | |||
"ctrl-n": "editor::MoveDown", | |||
"ctrl-b": "editor::MoveLeft", | |||
"ctrl-f": "editor::MoveRight", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to keep these ones. These are very deeply-ingrained macOS defaults.
@@ -100,13 +97,11 @@ | |||
"shift-down": "editor::SelectDown", | |||
"ctrl-shift-n": "editor::SelectDown", | |||
"shift-left": "editor::SelectLeft", | |||
"ctrl-shift-b": "editor::SelectLeft", | |||
"ctrl-shift-b": "editor::SelectToPreviousWordStart", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to keep ctrl-shift-b
and ctrl-shift-f
as they were (SelectLeft
and SelectRight
). Those are also very ubiquitous macOS bindings.
Follow up from #20378 Release Notes: - N/A
Closes #7688
Release Notes:
This primarily affects Zed's extra features:
alt-q
=>cmd-k q
on maOS,ctrl-k q
on Linux foreditor::Rewrap
alt-z
=>cmd-k z
on macOSctrl-k z
on Linux foreditor::ToggleSoftWrap
alt-m
=>ctrl-shift-m
forassistant::ToggleModelSelector
alt-v
=>ctrl-shift-v
for["editor::MovePageUp", { "center_cursor": true }]
(macOS only)alt-t
=>cmd-shift-r
on maOS,ctrl-shift-r
on Linux fortask::Spawn
(The previous binding foreditor::RevealInFileManager
now only applies in the project panel)alt-shift-t
=>alt-cmd-r
on maOS,ctrl-alt-r
on Linux fortask::Rerun
alt-shift-f
=>ctrl-shift-f
forproject_panel::SearchInDirectory
.But also overrides some bindings from Readline.
alt-h
=>alt-backspace
foreditor::DeleteToPreviousWordStart
alt-d
=>alt-delete
foreditor::DeleteToNextWordEnd
alt-f
=>alt-left
foreditor:: MoveToNextWordEnd
alt-b
=>alt-right
foreditor::MoveToNextWordStart
Note that
alt-t
andalt-shift-t
have been kept as aliases (because no-one complained aboutt
yet; but we may remove them completely in the future).