Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keybind for Editor::rewrap prevents @ from being typed in editor for certain keyboard-layouts on Mac #18104

Closed
1 task done
MrSubidubi opened this issue Sep 19, 2024 · 2 comments
Labels
bug [core label] editor Feedback for code editing, formatting, editor iterations, etc internationalization Feedback for human language support, translations, etc keymap / key binding Feedback for keyboard shortcuts, key mapping, etc macOS Platform-specific feedback for macOS behaviors, features, design, etc

Comments

@MrSubidubi
Copy link
Contributor

MrSubidubi commented Sep 19, 2024

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

Due to option-q being mapped to @ on certain keyboard-layouts for Mac, I am unable to enter the @-symbol in the editor as this conflicts with the keybinding introduced for Editor::rewrap in #17953 .

The affected keyboard-layouts include at least the QWERTZ - and the hungarian layout.

I had to manually remove the keybinding for Editor::rewrap in my keymap.json with

{
    "bindings": {
        "alt-q": null
    }
},
...

While this seems to be the most reasonable keybinding as per #4588 (comment) , I do not think this should cause symbol inputs to not be registered and require a manual unbind.

I believe this might be a Mac-only issue, as non-mac keyboards bind @ to Alt Gr + q, however I am not sure whether GPUI differentiates Alt and Alt Gr.

Environment

Zed: v0.154.0 (Zed Preview)
OS: macOS 14.6.1
Memory: 8 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your Zed.log file to this issue.

No response

@MrSubidubi MrSubidubi added admin read bug [core label] labels Sep 19, 2024
@miltonparedes
Copy link

Same here 😕, had to fix it with:

"ctrl-q": "editor::Rewrap",
"alt-q": null

@MrSubidubi MrSubidubi changed the title Keybind for Editor::rewrap prevents @ from being typed in editor for QWERTZ-layout on Mac Keybind for Editor::rewrap prevents @ from being typed in editor for certain keyboard-layouts on Mac Sep 22, 2024
@notpeter notpeter added internationalization Feedback for human language support, translations, etc keymap / key binding Feedback for keyboard shortcuts, key mapping, etc macOS Platform-specific feedback for macOS behaviors, features, design, etc and removed triage labels Sep 23, 2024
@JosephTLyons JosephTLyons added the editor Feedback for code editing, formatting, editor iterations, etc label Nov 1, 2024
@MrSubidubi
Copy link
Contributor Author

MrSubidubi commented Nov 7, 2024

#20378 adressed this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug [core label] editor Feedback for code editing, formatting, editor iterations, etc internationalization Feedback for human language support, translations, etc keymap / key binding Feedback for keyboard shortcuts, key mapping, etc macOS Platform-specific feedback for macOS behaviors, features, design, etc
Projects
None yet
Development

No branches or pull requests

4 participants