Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zeal version number in the About Zeal dialog needs to be updated. #246

Closed
RobertinoValue opened this issue Jan 6, 2015 · 9 comments
Closed
Milestone

Comments

@RobertinoValue
Copy link

Not a high priority.
The Zeal version number/date in zeal/zeal.pro needs to be updated.
Zeal version 20141123 displays 20140215.

https://github.com/jkozera/zeal/blob/7112812ddc08f0cf06e1a629c739d4e61e28a62e/zeal/zeal.pro#L71

@jkozera
Copy link
Member

jkozera commented Jan 6, 2015

It's by no means a complete fix, but the recent automated Shippable builds should display correct YYYYMMDD version numbers (they're automatically replaced in https://github.com/jkozera/zeal/blob/master/shippable.yml#L30)

Ideally I guess we should have proper version numbers and perhaps autodetect current one using git tags.

@trollixx trollixx self-assigned this Jan 9, 2015
@trollixx trollixx added this to the 0.1.0 milestone Jan 9, 2015
@trollixx trollixx removed this from the 0.1.0 milestone Jan 10, 2015
@trollixx trollixx removed their assignment Jan 10, 2015
@trollixx
Copy link
Member

Closing this as a duplicate of #203.

@RobertinoValue
Copy link
Author

How can this be a duplicate of (#)203?
I did not ask to change the version numbering, like was done in (#)203.

I just pointed out that Zeal version 20141123 still displayed 20140215.
Frankly I can't be bothered what type of version numbering is used.

The code I posted was in response to the casual remark/request (last line of his comment) by jkozera.
Besides (#)203 was closed when it showed up in my search results. I didn't open this issue until after lunch from work. Hours later.
I've removed the code to avoid further confusion.

@trollixx
Copy link
Member

@RobertinoValue there was no confusion. We need to improve the code, that generates version number. Getting one from the git tags is the best option. So, the proper fix for this issue would be implemented together with #203.

Anyway, we can keep this one open until a new release.

@trollixx trollixx reopened this Jan 11, 2015
@schlamar
Copy link
Contributor

It's by no means a complete fix, but the recent automated Shippable builds should display correct YYYYMMDD version numbers

Nope, 20150112054614 still shows 20140215.

@schlamar
Copy link
Contributor

This is hard coded in src.pro:

DEFINES += ZEAL_VERSION=\\\"20140215\\\"

@trollixx
Copy link
Member

Fixed in 022d4be and 8e3d3f0 (for Windows automatic builds).

@RobertinoValue
Copy link
Author

Thanks @schlamar.
(Not so duplicate after all.)

@trollixx trollixx modified the milestone: 0.1.0 Mar 15, 2015
@lock
Copy link

lock bot commented Sep 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for a related request.

@lock lock bot locked and limited conversation to collaborators Sep 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

4 participants